Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter is sensitive to locale #15576

Closed
refack opened this issue Sep 23, 2017 · 1 comment · Fixed by #15578
Closed

linter is sensitive to locale #15576

refack opened this issue Sep 23, 2017 · 1 comment · Fixed by #15578
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.

Comments

@refack
Copy link
Contributor

refack commented Sep 23, 2017

  • Version: master
  • Platform: Linux
  • Subsystem: build
[iojs@test-joyent-freebsd10-x64-2]$ LC_ALL=en_US node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules lib/internal/errors.js
[iojs@test-joyent-freebsd10-x64-2]$ LC_ALL=C node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules lib/internal/errors.js

/usr/home/iojs/build/workspace/node-test-linter/lib/internal/errors.js
  147:1  error  Errors in lib/internal/errors.js must be alphabetized  alphabetize-errors
  165:1  error  Errors in lib/internal/errors.js must be alphabetized  alphabetize-errors
  262:1  error  Errors in lib/internal/errors.js must be alphabetized  alphabetize-errors

✖ 3 problems (3 errors, 0 warnings)
@refack refack added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Sep 23, 2017
@TimothyGu
Copy link
Member

TimothyGu commented Sep 23, 2017

That's probably due to the use of String.prototype.localeCompare():

return errorForNode(previousNode).localeCompare(errorForNode(node)) < 0;

Edit: oh never mind, seems like @refack's got it already.

refack added a commit to refack/node that referenced this issue Sep 28, 2017
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 30, 2017
refack added a commit to refack/node that referenced this issue Oct 3, 2017
MylesBorins pushed a commit that referenced this issue Oct 3, 2017
MylesBorins pushed a commit that referenced this issue Dec 19, 2017
gibfahn pushed a commit that referenced this issue Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants