-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global proxy support #1490
Comments
+1 for proxy support |
This would be awesome yes. Wonder how much complex it is. |
+1, node (and every package I've ever used on node) appears to respect |
I would suggest to make use of #881 and run I don't think we need neither socks protocol implementation nor http connect tunneling here in core. |
Other solution I know of (all assume you can pass the http.Agent or are ok with overwriting the global). https://github.com/floatdrop/proxy-support |
I don't think proxy support in core is completely out of the question but it's a bit of a slippery slope. Speaking from prior experience where proxy support was added to an existing product, you start with HTTP CONNECT but you end up supporting everything from SOCKSv5 to HTTP POST, basic/digest/and-so-on auth, Kerberos, NTLMv1 and v2, custom CA chains, client certificates, certificate fingerprinting, etc., etc. There is no strict need to add it to core either because perfectly good user-land solutions exist. |
@nodejs/ctc ... what do we want to do with this one? The userland options look perfectly good. |
@jasnell Just my 2 cents as the original issue submitter.
ref: |
@bitinn .. understood! @nodejs/documentation ... perhaps adding some documentation on this would be good? |
Since I ran in this issue the other day: Initially saw a case for core, but after short pondering and discussion w/ @bnoordhuis I regarded @TooTallNate module and others fine for the purpose. Promoting those with docs or moving them under the umbrella might be a better approach, imo, especially with @bnoordhuis's concerns above. The use case would be also interesting for connecting to Tor, where you don't have many (code) client solution afaik. Generally I would be a fan of seeing this in core, but it's probably a mistake, dunno. |
-1 for putting it in core - @bnoordhuis words ring of truth and I share similar experience in scope creep and proxies. +1 for the docs guiding users for popular userland solutions. |
SGTM. Closing! |
Is it possible? Depends on whether we support both
http
andsocks
proxy, this can be tricky, because you need to proxy DNS queries as well.There are times we want io.js
http
andhttps
to work with a proxy, globally, be it http or socks. With current design, the best solution one can come up with is to patchhttp
andhttps
which often results in compatibility problems (because you need to overwrite defaulthttp.request
and Agent).Without a global proxy setting, one cannot easily instruct the whole io.js app to use such a proxy. A notable example is oauth modules, which usually depends on some request modules, and they often use it in a fashion that do not allow proxy settings.
I used these 2 repos to workaround the lack of proxy support, but I feel they are not very sustainable given how fast io.js are improving.
https://github.com/goinstant/global-tunnel
https://github.com/yahoo/dnscache
Let me know what you think, it can help a certain group of developers a lot (say ppl in tightly controlled corp network, and ppl in china).
The text was updated successfully, but these errors were encountered: