Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove mozilla's CA Root Certificates and use system Certificates instead #1256

Closed
darren opened this issue Mar 25, 2015 · 1 comment
Labels
tls Issues and PRs related to the tls subsystem.

Comments

@darren
Copy link

darren commented Mar 25, 2015

https://blog.mozilla.org/security/2015/03/23/revoking-trust-in-one-cnnic-intermediate-certificate/

I have removed CNNIC ROOT Certificate from system keychains, but this still works without any warning:

var https = require('https');

https.get('https://www.cnnic.com.cn/', function(res) {
    console.log("statusCode: ", res.statusCode);
    console.log("headers: ", res.headers);

    res.on('data', function(d) {
        process.stdout.write(d);
    });

}).on('error', function(e) {
    console.error(e);
});

while curl stops with certificate error:

$ curl https://www.cnnic.com.cn
curl: (60) SSL certificate problem: Invalid certificate chain
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
of Certificate Authority (CA) public keys (CA certs). If the default
bundle file isn't adequate, you can specify an alternate file
using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
the bundle, the certificate verification probably failed due to a
problem with the certificate (it might be expired, or the name might
not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
the -k (or --insecure) option.

@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Mar 25, 2015
@shigeki
Copy link
Contributor

shigeki commented Mar 25, 2015

When you specify ca option explicitly, iojs does not use the bundled root ca. You can use your own CA certs as similar to the --cacert option.

$ cat test-cnnic.js
var https = require('https');
var fs = require('fs');
var myca = fs.readFileSync('./my_ca.pem');
https.get({hostname: 'www.cnnic.com.cn', ca: myca}, function(res) {
    console.log("statusCode: ", res.statusCode);
    console.log("headers: ", res.headers);

    res.on('data', function(d) {
        process.stdout.write(d);
    });

}).on('error', function(e) {
    console.error(e);
});
$ ./iojs test-cnnic.js
{ [Error: self signed certificate in certificate chain] code: 'SELF_SIGNED_CERT_IN_CHAIN' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants