Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: setImmediate benchmarks in misc/ should be moved to timers/ #10926

Closed
mscdex opened this issue Jan 20, 2017 · 3 comments
Closed

benchmark: setImmediate benchmarks in misc/ should be moved to timers/ #10926

mscdex opened this issue Jan 20, 2017 · 3 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jan 20, 2017

  • Version: n/a
  • Platform: n/a
  • Subsystem: benchmark

As the title says, there are a few setImmediate benchmark files in benchmark/misc/ that should be moved to (or integrated with the existing benchmarks in) benchmark/timers/
@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jan 20, 2017
@joshuacolvin
Copy link
Contributor

I'd be happy to help with this

@Fishrock123
Copy link
Contributor

Sounds right to me.

@joshuacolvin joshuacolvin mentioned this issue Jan 26, 2017
Closed
@Trott
Copy link
Member

Trott commented Jan 31, 2017

Looks like this was resolved in #11010. Closing.
Thanks for the contribution! 🎉

@Trott Trott closed this as completed Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @Trott @Fishrock123 @joshuacolvin