Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6c7194c06312414ce5293f069d071f15bc669cad
Choose a base ref
..
head repository: nodejs/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cc505a505a166ad76e3c6eb9e2628758d522b6df
Choose a head ref
Showing with 651 additions and 207 deletions.
  1. +4 βˆ’0 .eslintrc.js
  2. +1 βˆ’1 .github/ISSUE_TEMPLATE/1-bug-report.yml
  3. +2 βˆ’2 .github/ISSUE_TEMPLATE/2-feature-request.yml
  4. +2 βˆ’2 .github/ISSUE_TEMPLATE/3-api-ref-docs-problem.yml
  5. +1 βˆ’1 .github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml
  6. +5 βˆ’5 .github/workflows/authors.yml
  7. +1 βˆ’1 .github/workflows/auto-start-ci.yml
  8. +6 βˆ’6 .github/workflows/build-tarball.yml
  9. +1 βˆ’1 .github/workflows/close-stalled.yml
  10. +1 βˆ’1 .github/workflows/commit-queue.yml
  11. +6 βˆ’6 .github/workflows/coverage-linux.yml
  12. +8 βˆ’8 .github/workflows/coverage-windows.yml
  13. +1 βˆ’1 .github/workflows/daily.yml
  14. +3 βˆ’3 .github/workflows/find-inactive-collaborators.yml
  15. +3 βˆ’3 .github/workflows/find-inactive-tsc.yml
  16. +3 βˆ’3 .github/workflows/license-builder.yml
  17. +1 βˆ’1 .github/workflows/linters.yml
  18. +1 βˆ’1 .github/workflows/notify-force-push.yml
  19. +6 βˆ’6 .github/workflows/test-asan.yml
  20. +6 βˆ’6 .github/workflows/test-macos.yml
  21. +6 βˆ’6 .github/workflows/tools.yml
  22. +3 βˆ’0 .mailmap
  23. +31 βˆ’0 .yamllint.yaml
  24. +10 βˆ’1 AUTHORS
  25. +10 βˆ’0 doc/api/cli.md
  26. +2 βˆ’0 doc/api/crypto.md
  27. +4 βˆ’1 doc/api/deprecations.md
  28. +52 βˆ’0 doc/api/globals.md
  29. +12 βˆ’12 doc/api/stream.md
  30. +3 βˆ’2 doc/api/tls.md
  31. +4 βˆ’2 doc/api/vm.md
  32. +3 βˆ’1 doc/api/webstreams.md
  33. +7 βˆ’0 doc/api_assets/style.css
  34. +3 βˆ’0 doc/node.1
  35. +51 βˆ’43 lib/.eslintrc.yaml
  36. +5 βˆ’3 lib/_tls_wrap.js
  37. +9 βˆ’0 lib/fs.js
  38. +26 βˆ’0 lib/internal/bootstrap/pre_execution.js
  39. +1 βˆ’0 lib/internal/crypto/webcrypto.js
  40. +4 βˆ’0 lib/internal/fs/promises.js
  41. +2 βˆ’0 lib/internal/main/worker_thread.js
  42. +1 βˆ’1 lib/internal/modules/esm/fetch_module.js
  43. +10 βˆ’1 lib/internal/process/promises.js
  44. +1 βˆ’1 lib/stream.js
  45. +48 βˆ’27 src/node_native_module_env.cc
  46. +4 βˆ’0 src/node_options.cc
  47. +1 βˆ’0 src/node_options.h
  48. +20 βˆ’1 src/util-inl.h
  49. +7 βˆ’1 src/util.h
  50. +36 βˆ’36 test/.eslintrc.yaml
  51. +6 βˆ’0 test/common/index.js
  52. +9 βˆ’0 test/parallel/test-fs-writev-promises.js
  53. +11 βˆ’1 test/parallel/test-fs-writev-sync.js
  54. +20 βˆ’1 test/parallel/test-fs-writev.js
  55. +13 βˆ’0 test/parallel/test-global-webcrypto-classes.js
  56. +13 βˆ’0 test/parallel/test-global-webcrypto.js
  57. +6 βˆ’0 test/parallel/test-intl.js
  58. +69 βˆ’1 test/parallel/test-stream-filter.js
  59. +47 βˆ’2 test/parallel/test-stream-forEach.js
  60. +2 βˆ’2 test/parallel/test-stream-iterator-helpers-test262-tests.mjs
  61. +14 βˆ’0 test/parallel/test-warn-multipleResolves.mjs
  62. +3 βˆ’3 tools/.eslintrc.yaml
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -340,5 +340,9 @@ module.exports = {
Headers: 'readable',
Request: 'readable',
Response: 'readable',
crypto: 'readable',
Crypto: 'readable',
CryptoKey: 'readable',
SubtleCrypto: 'readable',
},
};
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-bug-report.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: "\U0001F41B Bug report"
name: \U0001F41B Bug report
description: Create a report to help us improve
body:
- type: markdown
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/2-feature-request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "\U0001F680 Feature request"
name: \U0001F680 Feature request
description: Suggest an idea for this project
labels: ["feature request"]
labels: [feature request]
body:
- type: markdown
attributes:
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/3-api-ref-docs-problem.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: "\U0001F4D7 Open an issue regarding the Node.js API reference docs"
name: \U0001F4D7 Open an issue regarding the Node.js API reference docs
description: Let us know about any problematic API reference documents
labels: ["doc"]
labels: [doc]
body:
- type: markdown
attributes:
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Report a flaky test
description: Report a flaky test in our CI
labels: ["flaky-test"]
labels: [flaky-test]
body:
- type: markdown
attributes:
10 changes: 5 additions & 5 deletions .github/workflows/authors.yml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ name: Authors update
on:
schedule:
# Run once a week at 00:05 AM UTC on Sunday.
- cron: '5 0 * * 0'
- cron: 5 0 * * 0

workflow_dispatch:

@@ -15,7 +15,7 @@ jobs:
with:
fetch-depth: '0' # This is required to actually get all the authors
persist-credentials: false
- run: "tools/update-authors.js" # Run the AUTHORS tool
- run: tools/update-authors.js # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@v1 # Create a PR or update the Action's existing PR
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
@@ -25,7 +25,7 @@ jobs:
Here are some new additions to the AUTHORS file.
This is an automatically generated PR by the
`authors.yml` GitHub Action, which runs `tools/update-authors.js`.
branch: "actions/authors-update" # Custom branch *just* for this Action.
commit-message: "meta: update AUTHORS"
branch: actions/authors-update # Custom branch *just* for this Action.
commit-message: 'meta: update AUTHORS'
labels: meta
title: "meta: update AUTHORS"
title: 'meta: update AUTHORS'
2 changes: 1 addition & 1 deletion .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ on:
# optimistic, it can take longer to run.
# To understand why `schedule` is used instead of other events, refer to
# ./doc/contributing/commit-queue.md
- cron: "*/5 * * * *"
- cron: '*/5 * * * *'

env:
NODE_VERSION: lts/*
12 changes: 6 additions & 6 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
@@ -4,10 +4,10 @@ on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/build-tarball.yml'
push:
@@ -17,10 +17,10 @@ on:
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/build-tarball.yml'

2 changes: 1 addition & 1 deletion .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Close stalled issues and PRs
on:
schedule:
- cron: "0 0 * * *"
- cron: 0 0 * * *

env:
CLOSE_MESSAGE: >
2 changes: 1 addition & 1 deletion .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ on:
# be read-only, and the Action won't have access to any other repository
# secrets, which it needs to access Jenkins API.
schedule:
- cron: "*/5 * * * *"
- cron: '*/5 * * * *'

env:
NODE_VERSION: lts/*
12 changes: 6 additions & 6 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
@@ -5,18 +5,18 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '**.md'
- 'benchmark/**'
- 'deps/**'
- 'doc/**'
- benchmark/**
- deps/*
- doc/**
- .github/**
- '!.github/workflows/coverage-linux.yml'
push:
branches: [master, main]
paths-ignore:
- '**.md'
- 'benchmark/**'
- 'deps/**'
- 'doc/**'
- benchmark/**
- deps/**
- doc/**
- .github/**
- '!.github/workflows/coverage-linux.yml'

16 changes: 8 additions & 8 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
@@ -5,20 +5,20 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '**.md'
- 'benchmark/**'
- 'deps/**'
- 'doc/**'
- 'tools/**'
- benchmark/**
- deps/**
- doc/**
- tools/**
- .github/**
- '!.github/workflows/coverage-windows.yml'
push:
branches: [master, main]
paths-ignore:
- '**.md'
- 'benchmark/**'
- 'deps/**'
- 'doc/**'
- 'tools/**'
- benchmark/**
- deps/**
- doc/**
- tools/**
- .github/**
- '!.github/workflows/coverage-windows.yml'

2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: Node.js daily job
on:
workflow_dispatch:
schedule:
- cron: "0 0 * * *"
- cron: 0 0 * * *

env:
NODE_VERSION: lts/*
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: Find inactive collaborators
on:
schedule:
# Run every Monday at 4:05 AM UTC.
- cron: '5 4 * * 1'
- cron: 5 4 * * 1

workflow_dispatch:

@@ -37,6 +37,6 @@ jobs:
author: Node.js GitHub Bot <github-bot@iojs.org>
branch: actions/inactive-collaborators
body: This PR was generated by tools/find-inactive-collaborators.yml.
commit-message: "meta: move one or more collaborators to emeritus"
commit-message: 'meta: move one or more collaborators to emeritus'
labels: meta
title: "meta: move one or more collaborators to emeritus"
title: 'meta: move one or more collaborators to emeritus'
6 changes: 3 additions & 3 deletions .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: Find inactive TSC members
on:
schedule:
# Run every Tuesday 12:05 AM UTC.
- cron: '5 0 * * 2'
- cron: 5 0 * * 2

workflow_dispatch:

@@ -51,6 +51,6 @@ jobs:
@nodejs/tsc ${{ env.INACTIVE_TSC_HANDLES }}
${{ env.DETAILS_FOR_COMMIT_BODY }}
commit-message: "meta: move one or more TSC members to emeritus"
commit-message: 'meta: move one or more TSC members to emeritus'
labels: meta
title: "meta: move one or more TSC members to emeritus"
title: 'meta: move one or more TSC members to emeritus'
6 changes: 3 additions & 3 deletions .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ on:
schedule:
# 00:00:00 every Monday
# https://crontab.guru/#0_0_*_*_1
- cron: "0 0 * * 1"
- cron: 0 0 * * 1
workflow_dispatch:

jobs:
@@ -14,14 +14,14 @@ jobs:
- uses: actions/checkout@v2
with:
persist-credentials: false
- run: "./tools/license-builder.sh" # Run the license builder tool
- run: ./tools/license-builder.sh # Run the license builder tool
- uses: gr2m/create-or-update-pull-request-action@v1.x # Create a PR or update the Action's existing PR
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
branch: actions/license-builder
title: "doc: run license-builder"
title: 'doc: run license-builder'
body: >
License is likely out of date. This is an automatically generated PR by
the `license-builder.yml` GitHub Action, which runs `license-builder.sh`
2 changes: 1 addition & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -138,7 +138,7 @@ jobs:
persist-credentials: false
- uses: mszostok/codeowners-validator@v0.6.0
with:
checks: "files,duppatterns"
checks: files,duppatterns
lint-pr-url:
if: ${{ github.event.pull_request }}
runs-on: ubuntu-latest
2 changes: 1 addition & 1 deletion .github/workflows/notify-force-push.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ jobs:
env:
SLACK_COLOR: '#DE512A'
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: '${{ github.actor }} force-pushed to ${{ github.ref }}'
SLACK_TITLE: ${{ github.actor }} force-pushed to ${{ github.ref }}
SLACK_MESSAGE: |
A commit was force-pushed to <https://github.com/${{ github.repository }}/tree/${{ github.repository.default_branch }}|${{ github.repository }}@${{ github.repository.default_branch }}> by <https://github.com/${{ github.actor }}|${{ github.actor }}>
12 changes: 6 additions & 6 deletions .github/workflows/test-asan.yml
Original file line number Diff line number Diff line change
@@ -4,10 +4,10 @@ on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/test-asan.yml'
push:
@@ -18,10 +18,10 @@ on:
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/test-asan.yml'

12 changes: 6 additions & 6 deletions .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
@@ -4,10 +4,10 @@ on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/test-macos.yml'
push:
@@ -18,10 +18,10 @@ on:
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- '.mailmap'
- .mailmap
- '**.md'
- 'AUTHORS'
- 'doc/**'
- AUTHORS
- doc/**
- .github/**
- '!.github/workflows/test-macos.yml'

12 changes: 6 additions & 6 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ name: Tools update
on:
schedule:
# Run once a week at 00:05 AM UTC on Saturday.
- cron: '5 0 * * 6'
- cron: 5 0 * * 6

workflow_dispatch:

@@ -23,7 +23,7 @@ jobs:
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./update-eslint.sh
fi
- id: "lint-md-dependencies"
- id: lint-md-dependencies
run: |
cd tools/lint-md
npm ci
@@ -63,8 +63,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
body: "This is an automated update of ${{ matrix.id }} to ${{ env.NEW_VERSION }}."
branch: "actions/tools-update-${{ matrix.id }}" # Custom branch *just* for this Action.
commit-message: "tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}"
body: This is an automated update of ${{ matrix.id }} to ${{ env.NEW_VERSION }}.
branch: actions/tools-update-${{ matrix.id }} # Custom branch *just* for this Action.
commit-message: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
labels: tools
title: "tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}"
title: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
3 changes: 3 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
@@ -77,6 +77,7 @@ Brent Pendergraft <bpent3l@gmail.com>
Brett Kiefer <kiefer@gmail.com> <brett@trello.com>
Brian White <mscdex@mscdex.net>
Brian White <mscdex@mscdex.net> <mscdex@gmail.com>
Brian White <mscdex@mscdex.net> <mscdex@users.noreply.github.com>
Caleb Boyd <caleb.boyd@gmail.com>
Calvin Metcalf <calvin.metcalf@gmail.com> <calvin.metcalf@state.ma.us>
Calvin Metcalf <calvin.metcalf@gmail.com> <cmetcalf@appgeo.com>
@@ -219,6 +220,7 @@ James Hartig <fastest963@gmail.com> <james.hartig@grooveshark.com>
James Ide <ide@jameside.com> <ide@expo.io>
James M Snell <jasnell@gmail.com>
James Nimlos <james@nimlos.com>
James Sumners <james@sumners.email> <james.sumners@gmail.com>
Jan Krems <jan.krems@gmail.com> <jan.krems@groupon.com>
Jem Bezooyen <github@jem.dev> <jem@hipmedia.ca>
Jem Bezooyen <github@jem.dev> <jem@sendwithus.com>
@@ -365,6 +367,7 @@ Nigel Kibodeaux <nigelmail@gmail.com> <nigel@team.about.me>
Nikola Glavina <glavina.nikola5@gmail.com> <nikola.glavina@student.um.si>
Nikolai Vavilov <vvnicholas@gmail.com>
Nils Kuhnhenn <lain@volafile.io>
Nitzan Uziely <linkgoron@gmail.com> <Linkgoron@users.noreply.github.com>
Nitzan Uziely <linkgoron@gmail.com> <nitzan@testim.io>
Noah Rose Ledesma <noahroseledesma@seattleacademy.org>
Oliver Chang <ochang@chromium.org>
Loading