From fef87fee1de60c3d5db2652ee2004a6e78d112ff Mon Sep 17 00:00:00 2001 From: Sakthipriyan Vairamani Date: Tue, 14 Jul 2015 22:53:54 +0530 Subject: [PATCH] lib,test: add freelist deprecation and test As per the dicussion in https://github.com/nodejs/io.js/issues/569, this patch issues a deprecation warning when freelist module is required. A test file for freelist is also added. PR-URL: https://github.com/nodejs/io.js/pull/2176 Reviewed-By: Rich Trott Reviewed-By: Brendan Ashworth --- lib/freelist.js | 3 +++ test/parallel/test-freelist.js | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 test/parallel/test-freelist.js diff --git a/lib/freelist.js b/lib/freelist.js index 9300c1148754c4..ad33f971ebef5b 100644 --- a/lib/freelist.js +++ b/lib/freelist.js @@ -1,3 +1,6 @@ 'use strict'; +const util = require('internal/util'); + module.exports = require('internal/freelist'); +util.printDeprecationMessage('freelist module is deprecated.'); diff --git a/test/parallel/test-freelist.js b/test/parallel/test-freelist.js new file mode 100644 index 00000000000000..9a847a5f1ff31f --- /dev/null +++ b/test/parallel/test-freelist.js @@ -0,0 +1,33 @@ +'use strict'; + +// Flags: --expose-internals + +const assert = require('assert'); +const freelist = require('freelist'); +const internalFreelist = require('internal/freelist'); + +assert.equal(typeof freelist, 'object'); +assert.equal(typeof freelist.FreeList, 'function'); +assert.strictEqual(freelist, internalFreelist); + +const flist1 = new freelist.FreeList('flist1', 3, String); + +// Allocating when empty, should not change the list size +var result = flist1.alloc('test'); +assert.strictEqual(typeof result, 'string'); +assert.strictEqual(result, 'test'); +assert.strictEqual(flist1.list.length, 0); + +// Exhaust the free list +assert(flist1.free('test1')); +assert(flist1.free('test2')); +assert(flist1.free('test3')); + +// Now it should not return 'true', as max length is exceeded +assert.strictEqual(flist1.free('test4'), false); +assert.strictEqual(flist1.free('test5'), false); + +// At this point 'alloc' should just return the stored values +assert.strictEqual(flist1.alloc(), 'test1'); +assert.strictEqual(flist1.alloc(), 'test2'); +assert.strictEqual(flist1.alloc(), 'test3');