From fe442f6b5f9695ad6a11cec70f83b3f748e313a1 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 5 Feb 2018 15:02:18 -0500 Subject: [PATCH] test: properly tag anonymous namespaces For tests that use anonymous namespaces, some tagged the close of the namespace with 'namespace' while others used 'anonymous namespace'. It was suggested I should use 'anonymous namespace' in a recent PR review so make all of the tests consistent with this. PR-URL: https://github.com/nodejs/node/pull/18583 Reviewed-By: Eugene Ostroukhov Reviewed-By: Ruben Bridgewater Reviewed-By: Ben Noordhuis Reviewed-By: Colin Ihrig --- test/addons-napi/test_make_callback/binding.cc | 2 +- test/addons-napi/test_make_callback_recurse/binding.cc | 2 +- test/addons/async-hooks-id/binding.cc | 2 +- test/addons/async-resource/binding.cc | 2 +- test/addons/callback-scope/binding.cc | 2 +- test/addons/make-callback-recurse/binding.cc | 2 +- test/addons/make-callback/binding.cc | 2 +- test/cctest/test_inspector_socket_server.cc | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test/addons-napi/test_make_callback/binding.cc b/test/addons-napi/test_make_callback/binding.cc index 952dfcc1cb5bec..83db02b5fe2f4e 100644 --- a/test/addons-napi/test_make_callback/binding.cc +++ b/test/addons-napi/test_make_callback/binding.cc @@ -54,6 +54,6 @@ napi_value Init(napi_env env, napi_value exports) { return exports; } -} // namespace +} // anonymous namespace NAPI_MODULE(NODE_GYP_MODULE_NAME, Init) diff --git a/test/addons-napi/test_make_callback_recurse/binding.cc b/test/addons-napi/test_make_callback_recurse/binding.cc index b99c583d31d9f9..641f9f64237e5d 100644 --- a/test/addons-napi/test_make_callback_recurse/binding.cc +++ b/test/addons-napi/test_make_callback_recurse/binding.cc @@ -28,6 +28,6 @@ napi_value Init(napi_env env, napi_value exports) { return exports; } -} // namespace +} // anonymous namespace NAPI_MODULE(NODE_GYP_MODULE_NAME, Init) diff --git a/test/addons/async-hooks-id/binding.cc b/test/addons/async-hooks-id/binding.cc index d6d0385e617050..e410563a8bb613 100644 --- a/test/addons/async-hooks-id/binding.cc +++ b/test/addons/async-hooks-id/binding.cc @@ -22,6 +22,6 @@ void Initialize(Local exports) { NODE_SET_METHOD(exports, "getTriggerAsyncId", GetTriggerAsyncId); } -} // namespace +} // anonymous namespace NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/addons/async-resource/binding.cc b/test/addons/async-resource/binding.cc index 83629e757dedfc..857d74c2e62206 100644 --- a/test/addons/async-resource/binding.cc +++ b/test/addons/async-resource/binding.cc @@ -109,6 +109,6 @@ void Initialize(Local exports) { NODE_SET_METHOD(exports, "getResource", GetResource); } -} // namespace +} // anonymous namespace NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/addons/callback-scope/binding.cc b/test/addons/callback-scope/binding.cc index 34d452bbb7c710..52ffe8e91f6dce 100644 --- a/test/addons/callback-scope/binding.cc +++ b/test/addons/callback-scope/binding.cc @@ -69,6 +69,6 @@ void Initialize(v8::Local exports) { NODE_SET_METHOD(exports, "testResolveAsync", TestResolveAsync); } -} // namespace +} // anonymous namespace NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/addons/make-callback-recurse/binding.cc b/test/addons/make-callback-recurse/binding.cc index c42166c7455277..d1f9070f8a2a79 100644 --- a/test/addons/make-callback-recurse/binding.cc +++ b/test/addons/make-callback-recurse/binding.cc @@ -26,6 +26,6 @@ void Initialize(Local exports) { NODE_SET_METHOD(exports, "makeCallback", MakeCallback); } -} // namespace +} // anonymous namespace NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/addons/make-callback/binding.cc b/test/addons/make-callback/binding.cc index a5dfe46d773e82..13daf21cff07ae 100644 --- a/test/addons/make-callback/binding.cc +++ b/test/addons/make-callback/binding.cc @@ -34,6 +34,6 @@ void Initialize(v8::Local exports) { NODE_SET_METHOD(exports, "makeCallback", MakeCallback); } -} // namespace +} // anonymous namespace NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize) diff --git a/test/cctest/test_inspector_socket_server.cc b/test/cctest/test_inspector_socket_server.cc index 49a3ca9f95857d..9023ad43c1c75c 100644 --- a/test/cctest/test_inspector_socket_server.cc +++ b/test/cctest/test_inspector_socket_server.cc @@ -398,7 +398,7 @@ static const std::string WsHandshakeRequest(const std::string& target_id) { "Sec-WebSocket-Key: aaa==\r\n" "Sec-WebSocket-Version: 13\r\n\r\n"; } -} // namespace +} // anonymous namespace TEST_F(InspectorSocketServerTest, InspectorSessions) {