From f99d4c824ae5bebe9ebff27cb88993b33a65d5f9 Mon Sep 17 00:00:00 2001
From: James M Snell <jasnell@gmail.com>
Date: Wed, 12 Feb 2020 12:21:34 -0800
Subject: [PATCH] test: add known issue test for sync writable callback

If the write callbacks are invoked synchronously with an
error, onwriteError would cause the error event to be
emitted synchronously, making it impossible to attach
an error handler after the call that triggered it.

PR-URL: https://github.com/nodejs/node/pull/31756
Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947
Refs: https://github.com/nodejs/quic/pull/341
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
---
 .../test-stream-writable-sync-error.js        | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 test/known_issues/test-stream-writable-sync-error.js

diff --git a/test/known_issues/test-stream-writable-sync-error.js b/test/known_issues/test-stream-writable-sync-error.js
new file mode 100644
index 00000000000000..202cf7bf23e2fd
--- /dev/null
+++ b/test/known_issues/test-stream-writable-sync-error.js
@@ -0,0 +1,44 @@
+'use strict';
+const common = require('../common');
+
+// Tests for the regression in _stream_writable discussed in
+// https://github.com/nodejs/node/pull/31756
+
+// Specifically, when a write callback is invoked synchronously
+// with an error, and autoDestroy is not being used, the error
+// should still be emitted on nextTick.
+
+const { Writable } = require('stream');
+
+class MyStream extends Writable {
+  #cb = undefined;
+
+  constructor() {
+    super({ autoDestroy: false });
+  }
+
+  _write(_, __, cb) {
+    this.#cb = cb;
+  }
+
+  close() {
+    // Synchronously invoke the callback with an error.
+    this.#cb(new Error('foo'));
+  }
+}
+
+const stream = new MyStream();
+
+const mustError = common.mustCall(2);
+
+stream.write('test', () => {});
+
+// Both error callbacks should be invoked.
+
+stream.on('error', mustError);
+
+stream.close();
+
+// Without the fix in #31756, the error handler
+// added after the call to close will not be invoked.
+stream.on('error', mustError);