-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: always invoke callback before emitting error
Ensure the callback is always invoked before emitting the error in both sync and async case. PR-URL: #29293 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
- Loading branch information
Showing
7 changed files
with
116 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const { Writable } = require('stream'); | ||
const assert = require('assert'); | ||
|
||
// Ensure callback is always invoked before | ||
// error is emitted. Regardless if error was | ||
// sync or async. | ||
|
||
{ | ||
let callbackCalled = false; | ||
// Sync Error | ||
const writable = new Writable({ | ||
write: common.mustCall((buf, enc, cb) => { | ||
cb(new Error()); | ||
}) | ||
}); | ||
writable.on('error', common.mustCall(() => { | ||
assert.strictEqual(callbackCalled, true); | ||
})); | ||
writable.write('hi', common.mustCall(() => { | ||
callbackCalled = true; | ||
})); | ||
} | ||
|
||
{ | ||
let callbackCalled = false; | ||
// Async Error | ||
const writable = new Writable({ | ||
write: common.mustCall((buf, enc, cb) => { | ||
process.nextTick(cb, new Error()); | ||
}) | ||
}); | ||
writable.on('error', common.mustCall(() => { | ||
assert.strictEqual(callbackCalled, true); | ||
})); | ||
writable.write('hi', common.mustCall(() => { | ||
callbackCalled = true; | ||
})); | ||
} | ||
|
||
{ | ||
// Sync Error | ||
const writable = new Writable({ | ||
write: common.mustCall((buf, enc, cb) => { | ||
cb(new Error()); | ||
}) | ||
}); | ||
|
||
writable.on('error', common.mustCall()); | ||
|
||
let cnt = 0; | ||
// Ensure we don't live lock on sync error | ||
while (writable.write('a')) | ||
cnt++; | ||
|
||
assert.strictEqual(cnt, 0); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters