From f3dbc70cc4312359dcb84f58b9d2455fd750ed66 Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Wed, 24 Oct 2018 11:48:47 -0400 Subject: [PATCH] src: fix resource leak in node::fs::FileHandle PR-URL: https://github.com/nodejs/node/pull/23793 Reviewed-By: Anna Henningsen Reviewed-By: Joyee Cheung --- src/node_file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_file.h b/src/node_file.h index 96f8221520bd33..98bb7a9c663a59 100644 --- a/src/node_file.h +++ b/src/node_file.h @@ -406,7 +406,7 @@ class FileHandle : public AsyncWrap, public StreamBase { ref_.Reset(env->isolate(), ref); } - ~CloseReq() { + ~CloseReq() override { uv_fs_req_cleanup(req()); promise_.Reset(); ref_.Reset();