url: handle unicode hostname if empty

PR-URL: #49396 Fixes: #48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Nov 27, 2023 · f256b16 · f256b16
1 parent 67cb6f9
commit f256b16
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -168,7 +168,7 @@ void BindingData::Format(const FunctionCallbackInfo<Value>& args) {
     out->hash = std::nullopt;
   }
 
-  if (unicode) {
+  if (unicode && out->has_hostname()) {
     out->host = ada::idna::to_unicode(out->get_hostname());
   }
 

diff --git a/test/parallel/test-url-format-whatwg.js b/test/parallel/test-url-format-whatwg.js
@@ -140,3 +140,8 @@ assert.strictEqual(
   url.format(new URL('http://user:[email protected]:8080/path'), { unicode: true }),
   'http://user:pass@测试.com:8080/path'
 );
+
+assert.strictEqual(
+  url.format(new URL('tel:123')),
+  url.format(new URL('tel:123'), { unicode: true })
+);