doc: add optional step to onboarding doc

Include information on how to force push to the contributor's own branch so that pull requests show as merged in GitHub interface. PR-URL: #8774 Reviewed-By: Robert Jefe Lindstaedt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergstrom <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 11, 2016 · f07054d · f07054d
1 parent af84528
commit f07054d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/doc/onboarding.md b/doc/onboarding.md
@@ -184,6 +184,7 @@ Landing a PR
       * This will automatically close the PR when the commit lands in master.
     * `Refs: <full-url>`
       * Full URL of material that might provide additional useful information or context to someone trying to understand the change set or the thinking behind it.
+* Optional: Force push the amended commit to the branch you used to open the pull request. If your branch is called `bugfix`, then the command would be `git push --force-with-lease origin master:bugfix`. When the pull request is closed, this will cause the pull request to show the purple merged status rather than the red closed status that is usually used for pull requests that weren't merged. Only do this when landing your own contributions.
 * `git push upstream master`
     * Close the pull request with a "Landed in `<commit hash>`" comment.