src: change constructor behavior in stream_base-inl.h

Change ConstructorBehavior from kAllow to kThrow. Co-authored-by: Bruce A. MacNaughton <[email protected]> Refs: #23453 PR-URL: #23447 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 17, 2018 · ec7375a · ec7375a
1 parent b5f5585
commit ec7375a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h
@@ -275,29 +275,28 @@ void StreamBase::AddMethods(Environment* env, Local<FunctionTemplate> t) {
 
   Local<Signature> signature = Signature::New(env->isolate(), t);
 
-  // TODO(TimothyGu): None of these should have ConstructorBehavior::kAllow.
   Local<FunctionTemplate> get_fd_templ =
       env->NewFunctionTemplate(GetFD<Base>,
                                signature,
-                               v8::ConstructorBehavior::kAllow,
+                               v8::ConstructorBehavior::kThrow,
                                v8::SideEffectType::kHasNoSideEffect);
 
   Local<FunctionTemplate> get_external_templ =
       env->NewFunctionTemplate(GetExternal<Base>,
                                signature,
-                               v8::ConstructorBehavior::kAllow,
+                               v8::ConstructorBehavior::kThrow,
                                v8::SideEffectType::kHasNoSideEffect);
 
   Local<FunctionTemplate> get_bytes_read_templ =
       env->NewFunctionTemplate(GetBytesRead<Base>,
                                signature,
-                               v8::ConstructorBehavior::kAllow,
+                               v8::ConstructorBehavior::kThrow,
                                v8::SideEffectType::kHasNoSideEffect);
 
   Local<FunctionTemplate> get_bytes_written_templ =
       env->NewFunctionTemplate(GetBytesWritten<Base>,
                                signature,
-                               v8::ConstructorBehavior::kAllow,
+                               v8::ConstructorBehavior::kThrow,
                                v8::SideEffectType::kHasNoSideEffect);
 
   t->PrototypeTemplate()->SetAccessorProperty(env->fd_string(),