Skip to content

Commit

Permalink
deps: V8: cherry-pick d1253ae95b09
Browse files Browse the repository at this point in the history
Original commit message:

    [unwinder] Advance deprecation of the old unwinder API

    Chrome uses the new version now.

    Bug: v8:8116
    Change-Id: I59af8d2c6a897a852acd6de3a7938a4b8d3943e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2110015
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Peter Marshall <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#66796}

Refs: v8/v8@d1253ae

PR-URL: #32885
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
  • Loading branch information
addaleax authored and BethGriggs committed Apr 20, 2020
1 parent c3ecbc7 commit dfc66a6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18',
'v8_embedder_string': '-node.19',

##### V8 defaults for Node.js #####

Expand Down
6 changes: 3 additions & 3 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -9180,7 +9180,7 @@ class V8_EXPORT Isolate {
* Returns the UnwindState necessary for use with the Unwinder API.
*/
// TODO(petermarshall): Remove this API.
V8_DEPRECATE_SOON("Use entry_stubs + code_pages version.")
V8_DEPRECATED("Use entry_stubs + code_pages version.")
UnwindState GetUnwindState();

/**
Expand Down Expand Up @@ -10534,7 +10534,7 @@ class V8_EXPORT Unwinder {
* \return True on success.
*/
// TODO(petermarshall): Remove this API
V8_DEPRECATE_SOON("Use entry_stubs + code_pages version.")
V8_DEPRECATED("Use entry_stubs + code_pages version.")
static bool TryUnwindV8Frames(const UnwindState& unwind_state,
RegisterState* register_state,
const void* stack_base);
Expand Down Expand Up @@ -10562,7 +10562,7 @@ class V8_EXPORT Unwinder {
* (but not necessarily) be successful.
*/
// TODO(petermarshall): Remove this API
V8_DEPRECATE_SOON("Use code_pages version.")
V8_DEPRECATED("Use code_pages version.")
static bool PCIsInV8(const UnwindState& unwind_state, void* pc);

/**
Expand Down

0 comments on commit dfc66a6

Please sign in to comment.