test: check for invalid module type in vm.js

PR-URL: #24161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Nov 13, 2018 · dd9864b · dd9864b
1 parent 957ceaa
commit dd9864b
Showing 1 changed file with 24 additions and 6 deletions.
diff --git a/test/parallel/test-vm-module-dynamic-import.js b/test/parallel/test-vm-module-dynamic-import.js
@@ -68,16 +68,34 @@ async function testInvalid() {
   await result.catch(common.mustCall((e) => {
     assert.strictEqual(e.code, 'ERR_VM_MODULE_NOT_MODULE');
   }));
+
+  const s = new Script('import("foo")', {
+    importModuleDynamically: common.mustCall((specifier, wrap) => {
+      return undefined;
+    }),
+  });
+  let threw = false;
+  try {
+    await s.runInThisContext();
+  } catch (e) {
+    threw = true;
+    assert.strictEqual(e.code, 'ERR_VM_MODULE_NOT_MODULE');
+  }
+  assert(threw);
+}
+
+async function testInvalidimportModuleDynamically() {
+  assert.throws(
+    () => new Script(
+      'import("foo")',
+      { importModuleDynamically: false }),
+    { code: 'ERR_INVALID_ARG_TYPE' }
+  );
 }
 
-const done = common.mustCallAtLeast(3);
 (async function() {
   await testNoCallback();
-  done();
-
   await test();
-  done();
-
   await testInvalid();
-  done();
+  await testInvalidimportModuleDynamically();
 }()).then(common.mustCall());