Skip to content

Commit

Permalink
test: add AbortController to knownGlobals
Browse files Browse the repository at this point in the history
PR-URL: #53020
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
  • Loading branch information
lpinca authored and marco-ippolito committed Jul 19, 2024
1 parent 68fcbb6 commit d74bda4
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ function platformTimeout(ms) {
}

let knownGlobals = [
AbortController,
atob,
btoa,
clearImmediate,
Expand All @@ -292,15 +293,6 @@ let knownGlobals = [
queueMicrotask,
];

// TODO(@jasnell): This check can be temporary. AbortController is
// not currently supported in either Node.js 12 or 10, making it
// difficult to run tests comparatively on those versions. Once
// all supported versions have AbortController as a global, this
// check can be removed and AbortController can be added to the
// knownGlobals list above.
if (global.AbortController)
knownGlobals.push(global.AbortController);

if (global.gc) {
knownGlobals.push(global.gc);
}
Expand Down

0 comments on commit d74bda4

Please sign in to comment.