src: add debug CHECKs against empty handles

These checks were useful while investigating other issues; using empty `Local<>`s can be very un-debuggable, because that typically does not lead to assertions with debugging information but rather crashes based on accessing invalid memory. PR-URL: #26125 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Feb 28, 2019 · cbd3cf0 · cbd3cf0
1 parent be671c3
commit cbd3cf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/api/callback.cc b/src/api/callback.cc
@@ -139,6 +139,11 @@ MaybeLocal<Value> InternalMakeCallback(Environment* env,
                                        Local<Value> argv[],
                                        async_context asyncContext) {
   CHECK(!recv.IsEmpty());
+#ifdef DEBUG
+  for (int i = 0; i < argc; i++)
+    CHECK(!argv[i].IsEmpty());
+#endif
+
   InternalCallbackScope scope(env, recv, asyncContext);
   if (scope.Failed()) {
     return MaybeLocal<Value>();

diff --git a/src/node_errors.cc b/src/node_errors.cc
@@ -710,6 +710,7 @@ void DecorateErrorStack(Environment* env,
 void FatalException(Isolate* isolate,
                     Local<Value> error,
                     Local<Message> message) {
+  CHECK(!error.IsEmpty());
   HandleScope scope(isolate);
 
   Environment* env = Environment::GetCurrent(isolate);