Skip to content

Commit

Permalink
tools: revise line in configure.py for clarity
Browse files Browse the repository at this point in the history
* Replace unused identifier with Python convention `_`.
* Remove unneeded parentheses.
* Remove line-wrapping.

I confirmed that this doesn't change the output by running `./configure
--shared-zlib` and confirming that it created the same `common.gypi`
with and without these changes. The code changed here doesn't run unless
there is a `--shared-*` flag.

PR-URL: #36551
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
  • Loading branch information
Trott authored and danielleadams committed Jan 12, 2021
1 parent 3170636 commit cb7f73c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1347,8 +1347,7 @@ def configure_library(lib, output, pkgname=None):
output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib))

if getattr(options, shared_lib):
(pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = (
pkg_config(pkgname or lib))
(pkg_libs, pkg_cflags, pkg_libpath, _) = pkg_config(pkgname or lib)

if options.__dict__[shared_lib + '_includes']:
output['include_dirs'] += [options.__dict__[shared_lib + '_includes']]
Expand Down

0 comments on commit cb7f73c

Please sign in to comment.