Skip to content

Commit

Permalink
test: allow options for v8 testing
Browse files Browse the repository at this point in the history
Allow extra options when testing v8 in Node tree

PR-URL: #5502
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
mhdawson authored and Fishrock123 committed Mar 2, 2016
1 parent 2c619f2 commit c4d9cdb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ ifdef ENABLE_V8_TAP
TAP_V8_BENCHMARKS := --junitout v8-benchmarks-tap.xml
endif

V8_TEST_OPTIONS = $(V8_EXTRA_TEST_OPTIONS)
ifdef DISABLE_V8_I18N
V8_TEST_NO_I18N := --noi18n
V8_TEST_OPTIONS += --noi18n
V8_BUILD_OPTIONS += i18nsupport=off
endif

Expand Down Expand Up @@ -210,7 +211,7 @@ test-timers-clean:
test-v8:
# note: performs full test unless QUICKCHECK is specified
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \
--no-presubmit \
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
$(TAP_V8)
Expand Down

0 comments on commit c4d9cdb

Please sign in to comment.