Skip to content

Commit

Permalink
src: refactor deprecated v8::Function::Call call
Browse files Browse the repository at this point in the history
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
RomainLanz authored and rvagg committed Nov 28, 2018
1 parent 2a10f59 commit bf4c798
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1384,9 +1384,8 @@ void FatalException(Isolate* isolate,
fatal_try_catch.SetVerbose(false);

// This will return true if the JS layer handled it, false otherwise
Local<Value> caught =
fatal_exception_function.As<Function>()
->Call(process_object, 1, &error);
MaybeLocal<Value> caught = fatal_exception_function.As<Function>()->Call(
env->context(), process_object, 1, &error);

if (fatal_try_catch.HasTerminated())
return;
Expand All @@ -1395,7 +1394,7 @@ void FatalException(Isolate* isolate,
// The fatal exception function threw, so we must exit
ReportException(env, fatal_try_catch);
exit(7);
} else if (caught->IsFalse()) {
} else if (caught.ToLocalChecked()->IsFalse()) {
ReportException(env, error, message);

// fatal_exception_function call before may have set a new exit code ->
Expand Down

0 comments on commit bf4c798

Please sign in to comment.