From bc114152d08d026e1dc03e03984a021814ee316e Mon Sep 17 00:00:00 2001
From: cjihrig <cjihrig@gmail.com>
Date: Wed, 20 Feb 2019 11:10:18 -0500
Subject: [PATCH] test: simplify test-api-nohooks.js

PR-URL: https://github.com/nodejs/node/pull/26217
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/node-report/test-api-nohooks.js | 37 +++++++++++-----------------
 1 file changed, 14 insertions(+), 23 deletions(-)

diff --git a/test/node-report/test-api-nohooks.js b/test/node-report/test-api-nohooks.js
index 67d843c2701c17..478586fe8d8e14 100644
--- a/test/node-report/test-api-nohooks.js
+++ b/test/node-report/test-api-nohooks.js
@@ -1,28 +1,19 @@
+// Flags: --experimental-report
 'use strict';
 
-// Testcase to produce report via API call, using the no-hooks/no-signal
-// interface - i.e. require('node-report/api')
+// Test producing a report via API call, using the no-hooks/no-signal interface.
 const common = require('../common');
 common.skipIfReportDisabled();
-if (process.argv[2] === 'child') {
-  process.report.triggerReport();
-} else {
-  const helper = require('../common/report.js');
-  const spawn = require('child_process').spawn;
-  const assert = require('assert');
-  const tmpdir = require('../common/tmpdir');
-  tmpdir.refresh();
+const assert = require('assert');
+const helper = require('../common/report');
+const tmpdir = require('../common/tmpdir');
 
-  const child = spawn(process.execPath, ['--experimental-report',
-                                         __filename, 'child'],
-                      { cwd: tmpdir.path });
-  child.on('exit', common.mustCall((code) => {
-    const report_msg = 'No reports found';
-    const process_msg = 'Process exited unexpectedly';
-    assert.strictEqual(code, 0, process_msg + ':' + code);
-    const reports = helper.findReports(child.pid, tmpdir.path);
-    assert.strictEqual(reports.length, 1, report_msg);
-    const report = reports[0];
-    helper.validate(report);
-  }));
-}
+common.expectWarning('ExperimentalWarning',
+                     'report is an experimental feature. This feature could ' +
+                     'change at any time');
+tmpdir.refresh();
+process.report.setOptions({ path: tmpdir.path });
+process.report.triggerReport();
+const reports = helper.findReports(process.pid, tmpdir.path);
+assert.strictEqual(reports.length, 1);
+helper.validate(reports[0]);