From b8c7a1ecf8f1e9773d587f9a49b47b31e5ff11ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 17 Apr 2023 08:55:34 +0200 Subject: [PATCH] deps: patch V8 to 11.3.244.8 Refs: https://github.com/v8/v8/compare/11.3.244.4...11.3.244.8 PR-URL: https://github.com/nodejs/node/pull/47536 Reviewed-By: Antoine du Hamel Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng --- deps/v8/include/v8-version.h | 2 +- deps/v8/infra/mb/mb_config.pyl | 2 ++ deps/v8/infra/testing/builders.pyl | 17 +++++++++++++++++ deps/v8/src/builtins/builtins-error.cc | 3 +++ deps/v8/tools/builtins-pgo/profile_only.py | 3 ++- deps/v8/tools/whitespace.txt | 2 ++ 6 files changed, 27 insertions(+), 2 deletions(-) diff --git a/deps/v8/include/v8-version.h b/deps/v8/include/v8-version.h index f2146fa1ea3326..4b0ee2b11c4cd9 100644 --- a/deps/v8/include/v8-version.h +++ b/deps/v8/include/v8-version.h @@ -11,7 +11,7 @@ #define V8_MAJOR_VERSION 11 #define V8_MINOR_VERSION 3 #define V8_BUILD_NUMBER 244 -#define V8_PATCH_LEVEL 4 +#define V8_PATCH_LEVEL 8 // Use 1 for candidates and 0 otherwise. // (Boolean macro values are not supported by all preprocessors.) diff --git a/deps/v8/infra/mb/mb_config.pyl b/deps/v8/infra/mb/mb_config.pyl index 741ae615cbd2cb..41e5ed04194800 100644 --- a/deps/v8/infra/mb/mb_config.pyl +++ b/deps/v8/infra/mb/mb_config.pyl @@ -55,6 +55,8 @@ # PGO 'V8 Linux PGO instrumentation - builder' : 'builtins_profiling_x86', 'V8 Linux64 PGO instrumentation - builder' : 'builtins_profiling_x64', + 'V8 Win32 PGO instrumentation - builder' : 'builtins_profiling_x86', + 'V8 Win64 PGO instrumentation - builder' : 'builtins_profiling_x64', # Linux. 'V8 Linux - builder': 'release_x86_gcmole', diff --git a/deps/v8/infra/testing/builders.pyl b/deps/v8/infra/testing/builders.pyl index 63d675bddd23dd..565e33620e3554 100644 --- a/deps/v8/infra/testing/builders.pyl +++ b/deps/v8/infra/testing/builders.pyl @@ -1911,6 +1911,15 @@ {'name': 'v8testing', 'shards': 5}, ], }, + 'V8 Win32 PGO instrumentation - builder' : { + 'swarming_dimensions': { + 'cpu': 'x86-64', + 'os': 'Windows-10-19045', + }, + 'tests': [ + {'name': 'pgo_instrumentation'} + ], + }, 'V8 Win64': { 'swarming_dimensions': { 'os': 'Windows-10-19045', @@ -1951,6 +1960,14 @@ {'name': 'v8testing', 'shards': 5}, ], }, + 'V8 Win64 PGO instrumentation - builder' : { + 'swarming_dimensions': { + 'os': 'Windows-10-19045', + }, + 'tests': [ + {'name': 'pgo_instrumentation'} + ], + }, ############################################################################## # Ports. 'V8 Android Arm64 - N5X': { diff --git a/deps/v8/src/builtins/builtins-error.cc b/deps/v8/src/builtins/builtins-error.cc index 01e016252ceb6c..14c06022a9ecca 100644 --- a/deps/v8/src/builtins/builtins-error.cc +++ b/deps/v8/src/builtins/builtins-error.cc @@ -35,6 +35,9 @@ BUILTIN(ErrorCaptureStackTrace) { THROW_NEW_ERROR_RETURN_FAILURE( isolate, NewTypeError(MessageTemplate::kInvalidArgument, object_obj)); } + if (object_obj->IsJSGlobalProxy()) { + return ReadOnlyRoots(isolate).undefined_value(); + } Handle object = Handle::cast(object_obj); Handle caller = args.atOrUndefined(isolate, 2); diff --git a/deps/v8/tools/builtins-pgo/profile_only.py b/deps/v8/tools/builtins-pgo/profile_only.py index 7d938e983d48a1..cf3d43c4c6e3f6 100755 --- a/deps/v8/tools/builtins-pgo/profile_only.py +++ b/deps/v8/tools/builtins-pgo/profile_only.py @@ -23,6 +23,7 @@ def parse_arguments(): 'the isolate aready contains the instrumented binary.')) parser.add_argument( '--v8-target-cpu', + default='pgo', help='target cpu to build the profile for: x64 or arm64') parser.add_argument( '--benchmark_path', @@ -33,7 +34,7 @@ def parse_arguments(): '--d8-path', default=Path('./out/build/d8'), help=('path to the d8 executable, by default `./out/build/d8` in ' - 'swarming context. Use together with `--profile-only`'), + 'swarming context'), type=Path) parser.add_argument('--output-dir', type=Path) return parser.parse_args() diff --git a/deps/v8/tools/whitespace.txt b/deps/v8/tools/whitespace.txt index 92fef9296e6c69..a7c5d57c465fe0 100644 --- a/deps/v8/tools/whitespace.txt +++ b/deps/v8/tools/whitespace.txt @@ -17,3 +17,5 @@ Today's answer to life the universe and everything is 6728! Today's answer to life the universe and everything is 6728!! Off-course, this is wrong ... .. +What's a fish without eyes? A fsh! +