process: wait for 'exit' before printing result

Co-authored-by: Vinícius Lourenço <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> PR-URL: #52172 Refs: #52077 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Mar 25, 2024 · a8b21fd · a8b21fd
1 parent 8bd3cb2
commit a8b21fd
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 4 deletions.
diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -119,7 +119,10 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) {
     });
     if (print) {
       const { log } = require('internal/console/global');
-      log(result);
+
+      process.on('exit', () => {
+        log(result);
+      });
     }
 
     if (origModule !== undefined)

diff --git a/test/parallel/test-cli-print-promise.mjs b/test/parallel/test-cli-print-promise.mjs
@@ -29,7 +29,7 @@ describe('--print with a promise', { concurrency: !process.env.TEST_PARALLEL },
       code: 0,
       signal: null,
       stderr: '',
-      stdout: 'Promise { <pending> }\n',
+      stdout: 'Promise { 42 }\n',
     });
   });
 
@@ -50,7 +50,7 @@ describe('--print with a promise', { concurrency: !process.env.TEST_PARALLEL },
   it('should output something if process exits before promise settles', async () => {
     const result = await spawnPromisified(execPath, [
       '--print',
-      'setTimeout(process.exit,100, 0);timers.promises.setTimeout(200)',
+      'setTimeout(process.exit, 100, 0);timers.promises.setTimeout(200)',
     ]);
 
     assert.deepStrictEqual(result, {
@@ -61,6 +61,20 @@ describe('--print with a promise', { concurrency: !process.env.TEST_PARALLEL },
     });
   });
 
+  it('should respect exit code when process exits before promise settles', async () => {
+    const result = await spawnPromisified(execPath, [
+      '--print',
+      'setTimeout(process.exit, 100, 42);timers.promises.setTimeout(200)',
+    ]);
+
+    assert.deepStrictEqual(result, {
+      code: 42,
+      signal: null,
+      stderr: '',
+      stdout: 'Promise { <pending> }\n',
+    });
+  });
+
   it('should handle rejected promises', async () => {
     const result = await spawnPromisified(execPath, [
       '--unhandled-rejections=none',
@@ -87,7 +101,52 @@ describe('--print with a promise', { concurrency: !process.env.TEST_PARALLEL },
       code: 0,
       signal: null,
       stderr: '',
-      stdout: 'Promise { <pending> }\n',
+      stdout: 'Promise { <rejected> 1 }\n',
+    });
+  });
+
+  it('should handle thenable that resolves', async () => {
+    const result = await spawnPromisified(execPath, [
+      '--unhandled-rejections=none',
+      '--print',
+      '({ then(r) { r(42) } })',
+    ]);
+
+    assert.deepStrictEqual(result, {
+      code: 0,
+      signal: null,
+      stderr: '',
+      stdout: '{ then: [Function: then] }\n',
+    });
+  });
+
+  it('should handle thenable that rejects', async () => {
+    const result = await spawnPromisified(execPath, [
+      '--unhandled-rejections=none',
+      '--print',
+      '({ then(_, r) { r(42) } })',
+    ]);
+
+    assert.deepStrictEqual(result, {
+      code: 0,
+      signal: null,
+      stderr: '',
+      stdout: '{ then: [Function: then] }\n',
+    });
+  });
+
+  it('should handle Promise.prototype', async () => {
+    const result = await spawnPromisified(execPath, [
+      '--unhandled-rejections=none',
+      '--print',
+      'Promise.prototype',
+    ]);
+
+    assert.deepStrictEqual(result, {
+      code: 0,
+      signal: null,
+      stderr: '',
+      stdout: 'Object [Promise] {}\n',
     });
   });
 });