From a65762cab6edf33d87a129e406f633dfa445bb23 Mon Sep 17 00:00:00 2001 From: Brendan Ashworth Date: Wed, 27 May 2015 20:42:33 -0700 Subject: [PATCH] src: remove old code The Socket writable only change was added and implemented in the constructor around 5885f464f0ad372efa7e, but this was never removed. The libev counter issue is no longer prudent; the test remains in test/sequential/test-regress-GH-1726. PR-URL: https://github.com/nodejs/io.js/pull/1819 Reviewed-By: Ben Noordhuis --- src/node.js | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/node.js b/src/node.js index 065c337e743993..4521afbf0cbac8 100644 --- a/src/node.js +++ b/src/node.js @@ -578,12 +578,6 @@ var tty = NativeModule.require('tty'); stream = new tty.WriteStream(fd); stream._type = 'tty'; - - // Hack to have stream not keep the event loop alive. - // See https://github.com/joyent/node/issues/1726 - if (stream._handle && stream._handle.unref) { - stream._handle.unref(); - } break; case 'FILE': @@ -600,20 +594,7 @@ readable: false, writable: true }); - - // FIXME Should probably have an option in net.Socket to create a - // stream from an existing fd which is writable only. But for now - // we'll just add this hack and set the `readable` member to false. - // Test: ./node test/fixtures/echo.js < /etc/passwd - stream.readable = false; - stream.read = null; stream._type = 'pipe'; - - // FIXME Hack to have stream not keep the event loop alive. - // See https://github.com/joyent/node/issues/1726 - if (stream._handle && stream._handle.unref) { - stream._handle.unref(); - } break; default: