Skip to content

Commit

Permalink
src: remove deprecated wasm type check
Browse files Browse the repository at this point in the history
This removes uses of the "IsWebAssemblyCompiledModule" method, which is
deprecated in V8 v8.1 and will be removed in v8.2.
We could replace it by "IsWasmModuleObject", but since it's unused in
node anyway, I just remove the definition.

PR-URL: #32116
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
backes authored and mmarchini committed Mar 18, 2020
1 parent c080b2d commit a63db7f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 3 additions & 0 deletions doc/api/util.md
Original file line number Diff line number Diff line change
Expand Up @@ -1891,8 +1891,11 @@ util.types.isWeakSet(new WeakSet()); // Returns true
### `util.types.isWebAssemblyCompiledModule(value)`
<!-- YAML
added: v10.0.0
deprecated: REPLACEME
-->

> Stability: 0 - Deprecated: Use `value instanceof WebAssembly.Module` instead.
* `value` {any}
* Returns: {boolean}

Expand Down
1 change: 0 additions & 1 deletion src/node_types.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ namespace {
V(DataView) \
V(SharedArrayBuffer) \
V(Proxy) \
V(WebAssemblyCompiledModule) \
V(ModuleNamespaceObject) \


Expand Down

0 comments on commit a63db7f

Please sign in to comment.