From a45e1f9f98eabf08148f0881aef8e8a08890c0f0 Mon Sep 17 00:00:00 2001 From: Ali Ijaz Sheikh Date: Sat, 13 Feb 2016 08:02:45 +0500 Subject: [PATCH] src: fix deprecated SetWeak usage in base-object PR-URL: https://github.com/nodejs/node/pull/5204 Reviewed-By: bnoordhuis - Ben Noordhuis Reviewed-By: indutny - Fedor Indutny --- src/base-object-inl.h | 5 +++-- src/base-object.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/base-object-inl.h b/src/base-object-inl.h index db0daa1e82f559..87159ffc6838c7 100644 --- a/src/base-object-inl.h +++ b/src/base-object-inl.h @@ -39,7 +39,7 @@ inline Environment* BaseObject::env() const { template inline void BaseObject::WeakCallback( - const v8::WeakCallbackData& data) { + const v8::WeakCallbackInfo& data) { Type* self = data.GetParameter(); self->persistent().Reset(); delete self; @@ -53,7 +53,8 @@ inline void BaseObject::MakeWeak(Type* ptr) { CHECK_GT(handle->InternalFieldCount(), 0); Wrap(handle, ptr); handle_.MarkIndependent(); - handle_.SetWeak(ptr, WeakCallback); + handle_.SetWeak(ptr, WeakCallback, + v8::WeakCallbackType::kParameter); } diff --git a/src/base-object.h b/src/base-object.h index 5a7b95827e8f11..8574a904e71b1a 100644 --- a/src/base-object.h +++ b/src/base-object.h @@ -40,7 +40,7 @@ class BaseObject { template static inline void WeakCallback( - const v8::WeakCallbackData& data); + const v8::WeakCallbackInfo& data); v8::Persistent handle_; Environment* env_;