process: properly close file descriptor on exit

This makes sure the file descriptor is closed syncronously on exit instead of using the asyncronous version which should not be used on exit. PR-URL: #24972 Refs: https://github.com/nodejs/node/pull/24965/files#r240770314 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Feb 12, 2019 · a4068d9 · a4068d9
1 parent 944e75d
commit a4068d9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/internal/process/warning.js b/lib/internal/process/warning.js
@@ -22,7 +22,9 @@ function writeOut(message) {
 function onClose(fd) {
   return () => {
     if (fs === null) fs = require('fs');
-    fs.close(fd, nop);
+    try {
+      fs.closeSync(fd);
+    } catch {}
   };
 }