tools: fix --v8-non-optimized-debug for v18.x

Disable SLOW_DCHECKs on v18.x because they don't compile without the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887 if used in constexpr, which can happen in other floated patches. PR-URL: #50612 Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Nov 27, 2023 · a1c9403 · a1c9403
1 parent 7af5427
commit a1c9403
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi
@@ -90,6 +90,11 @@
     # Set to 1 to enable DCHECKs in release builds.
     'dcheck_always_on%': 0,
 
+    # For v18.x, disable SLOW_DCHECKs because they don't compile without
+    # the patches in https://bugs.chromium.org/p/v8/issues/detail?id=12887
+    # if used in constexpr, which can happen in other floated patches.
+    'v8_enable_slow_dchecks%': 0,
+
     # Sets -DV8_ENABLE_FUTURE.
     'v8_enable_future%': 0,