From 9c7b87b9a16837c9bd3d7b6514cdee6f0933bfbc Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Thu, 22 Nov 2018 00:38:05 +0200 Subject: [PATCH] doc,meta: update PR approving info Refs: https://github.com/nodejs/node/pull/22255 PR-URL: https://github.com/nodejs/node/pull/24561 Reviewed-By: Rich Trott Reviewed-By: Anatoli Papirovski --- doc/guides/contributing/pull-requests.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index ea28001b6957d3..959d388de1d0c7 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -347,7 +347,8 @@ unhelpful is likely safe to ignore. ### Step 10: Landing In order to land, a Pull Request needs to be reviewed and [approved][] by -at least one Node.js Collaborator and pass a +at least two Node.js Collaborators (one Collaborator approval is enough if the +pull request has been open for more than 7 days) and pass a [CI (Continuous Integration) test run][]. After that, as long as there are no objections from other contributors, the Pull Request can be merged. If you find your Pull Request waiting longer than you expect, see the