lib: fix MIME overmatch in data URLs

This commit adds the delimiters ^ and $ to the regex that matches the MIME types for `data:` URLs. PR-URL: #49104 Fixes: #48957 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Nov 26, 2023 · 981aa78 · 981aa78
1 parent d585d13
commit 981aa78
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/internal/modules/esm/formats.js b/lib/internal/modules/esm/formats.js
@@ -38,7 +38,7 @@ if (experimentalWasmModules) {
 function mimeToFormat(mime) {
   if (
     RegExpPrototypeExec(
-      /\s*(text|application)\/javascript\s*(;\s*charset=utf-?8\s*)?/i,
+      /^\s*(text|application)\/javascript\s*(;\s*charset=utf-?8\s*)?$/i,
       mime,
     ) !== null
   ) { return 'module'; }

diff --git a/test/es-module/test-esm-invalid-data-urls.js b/test/es-module/test-esm-invalid-data-urls.js
@@ -18,4 +18,7 @@ const assert = require('assert');
     code: 'ERR_UNKNOWN_MODULE_FORMAT',
     message: 'Unknown module format: text/css for URL data:text/css,.error { color: red; }',
   });
+  await assert.rejects(import('data:WRONGtext/javascriptFORMAT,console.log("hello!");'), {
+    code: 'ERR_UNKNOWN_MODULE_FORMAT',
+  });
 })().then(common.mustCall());