Skip to content

Commit

Permalink
deps: V8: cherry-pick f0057afc2fb6
Browse files Browse the repository at this point in the history
Original commit message:

    [api] Remove deprecated and non-functional method

    The functionality was not used since a long time, and was hence removed
    for the 8.1 branch, and the method was deprecated.
    This CL removed the deprecated method completely.

    [email protected]

    Bug: v8:10155
    Change-Id: Iae299d64decb7230d38c2fda8d269a7b0387bb0d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033169
    Reviewed-by: Adam Klein <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#66167}

Refs: v8/v8@f0057af

PR-URL: #32885
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
  • Loading branch information
addaleax authored and BethGriggs committed Apr 20, 2020
1 parent 07d4372 commit 9568fbc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',

##### V8 defaults for Node.js #####

Expand Down
8 changes: 0 additions & 8 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -2446,14 +2446,6 @@ class V8_EXPORT ValueDeserializer {
*/
void SetSupportsLegacyWireFormat(bool supports_legacy_wire_format);

/**
* Expect inline wasm in the data stream (rather than in-memory transfer)
*/
V8_DEPRECATED(
"Wasm module serialization is only supported via explicit methods, e.g. "
"CompiledWasmModule::Serialize()")
void SetExpectInlineWasm(bool allow_inline_wasm) {}

/**
* Reads the underlying wire format version. Likely mostly to be useful to
* legacy code reading old wire format versions. Must be called after
Expand Down

0 comments on commit 9568fbc

Please sign in to comment.