From 93712068dbe6e8ccaed375e2887e354ad5e23078 Mon Sep 17 00:00:00 2001 From: jakecastelli <38635403+jakecastelli@users.noreply.github.com> Date: Thu, 27 Jun 2024 05:15:47 +0930 Subject: [PATCH] test: refactor, add assertion to http-request-end PR-URL: https://github.com/nodejs/node/pull/53411 Reviewed-By: Luigi Pinca --- test/parallel/test-http-request-end.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/test/parallel/test-http-request-end.js b/test/parallel/test-http-request-end.js index d762f459db27f0..6f141fda1ea4e8 100644 --- a/test/parallel/test-http-request-end.js +++ b/test/parallel/test-http-request-end.js @@ -20,11 +20,12 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const http = require('http'); const expected = 'Post Body For Test'; +const expectedStatusCode = 200; const server = http.Server(function(req, res) { let result = ''; @@ -34,12 +35,12 @@ const server = http.Server(function(req, res) { result += chunk; }); - req.on('end', function() { + req.on('end', common.mustCall(() => { assert.strictEqual(result, expected); - res.writeHead(200); + res.writeHead(expectedStatusCode); res.end('hello world\n'); server.close(); - }); + })); }); @@ -49,12 +50,9 @@ server.listen(0, function() { path: '/', method: 'POST' }, function(res) { - console.log(res.statusCode); + assert.strictEqual(res.statusCode, expectedStatusCode); res.resume(); - }).on('error', function(e) { - console.log(e.message); - process.exit(1); - }); + }).on('error', common.mustNotCall()); const result = req.end(expected);