Skip to content

Commit

Permalink
test: validate errors in test-buffer-indexof
Browse files Browse the repository at this point in the history
* validate errors in assert.throws
* use arrow functions

PR-URL: #10752
Backport-PR-URL: #13785
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
edsadr authored and gibfahn committed Jun 20, 2017
1 parent 4832ec5 commit 9243b9d
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions test/parallel/test-buffer-indexof.js
Original file line number Diff line number Diff line change
Expand Up @@ -346,15 +346,20 @@ assert.strictEqual(Buffer.from('aaaaa').indexOf('b', 'ucs2'), -1);
}
}

assert.throws(function() {
b.indexOf(function() { });
});
assert.throws(function() {
const argumentExpected =
/^TypeError: "val" argument must be string, number or Buffer$/;

assert.throws(() => {
b.indexOf(() => { });
}, argumentExpected);

assert.throws(() => {
b.indexOf({});
});
assert.throws(function() {
}, argumentExpected);

assert.throws(() => {
b.indexOf([]);
});
}, argumentExpected);

// Test weird offset arguments.
// The following offsets coerce to NaN or 0, searching the whole Buffer
Expand Down

0 comments on commit 9243b9d

Please sign in to comment.