From 8f153092d86b0605af8a2ef294dc310fefa83e30 Mon Sep 17 00:00:00 2001
From: Ruben Bridgewater <ruben@bridgewater.de>
Date: Wed, 3 Jan 2018 16:25:07 +0100
Subject: [PATCH] util: change %o depth default
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Since the default for depth is changed to `Infinity` it is logical
to change the %o default to the same as well.

Using %o with `util.format` will now always print the whole object.

PR-URL: https://github.com/nodejs/node/pull/17907
Refs: https://github.com/nodejs/node/issues/12693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
---
 doc/api/util.md | 14 ++++++++------
 lib/util.js     |  2 +-
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/doc/api/util.md b/doc/api/util.md
index ae4cec72e11c7d..864a866a7311b5 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -187,6 +187,9 @@ property take precedence over `--trace-deprecation` and
 <!-- YAML
 added: v0.5.3
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/17907
+    description: The `%o` specifiers `depth` option is now set to Infinity.
   - version: v8.4.0
     pr-url: https://github.com/nodejs/node/pull/14558
     description: The `%o` and `%O` specifiers are supported now.
@@ -209,12 +212,11 @@ corresponding argument. Supported placeholders are:
 contains circular references.
 * `%o` - Object. A string representation of an object
   with generic JavaScript object formatting.
-  Similar to `util.inspect()` with options `{ showHidden: true, depth: 4, showProxy: true }`.
-  This will show the full object including non-enumerable symbols and properties.
-* `%O` - Object. A string representation of an object
-  with generic JavaScript object formatting.
-  Similar to `util.inspect()` without options.
-  This will show the full object not including non-enumerable symbols and properties.
+  Similar to `util.inspect()` with options `{ showHidden: true, showProxy: true }`.
+  This will show the full object including non-enumerable properties and proxies.
+* `%O` - Object. A string representation of an object with generic JavaScript
+  object formatting. Similar to `util.inspect()` without options. This will show
+  the full object not including non-enumerable properties and proxies.
 * `%%` - single percent sign (`'%'`). This does not consume an argument.
 
 If the placeholder does not have a corresponding argument, the placeholder is
diff --git a/lib/util.js b/lib/util.js
index 9d1739f786fbbf..541577db08e221 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -195,7 +195,7 @@ function format(f) {
             break;
           case 111: // 'o'
             tempStr = inspect(arguments[a++],
-                              { showHidden: true, depth: 4, showProxy: true });
+                              { showHidden: true, showProxy: true });
             break;
           case 105: // 'i'
             tempStr = `${parseInt(arguments[a++])}`;