dgram: sync the old handle state to new handle

PR-URL: #46041 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
nodejs · Jan 31, 2023 · 8de6425 · 8de6425
1 parent c8492b7
commit 8de6425
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/dgram.js b/lib/dgram.js
@@ -184,7 +184,10 @@ function startListening(socket) {
 function replaceHandle(self, newHandle) {
   const state = self[kStateSymbol];
   const oldHandle = state.handle;
-
+  // Sync the old handle state to new handle
+  if (!oldHandle.hasRef() && typeof newHandle.unref === 'function') {
+    newHandle.unref();
+  }
   // Set up the handle that we got from primary.
   newHandle.lookup = oldHandle.lookup;
   newHandle.bind = oldHandle.bind;

diff --git a/test/parallel/test-dgram-unref-in-cluster.js b/test/parallel/test-dgram-unref-in-cluster.js
@@ -0,0 +1,23 @@
+'use strict';
+const common = require('../common');
+const dgram = require('dgram');
+const cluster = require('cluster');
+const assert = require('assert');
+
+if (common.isWindows)
+  common.skip('dgram clustering is currently not supported on Windows.');
+
+if (cluster.isPrimary) {
+  cluster.fork();
+} else {
+  const socket = dgram.createSocket('udp4');
+  socket.unref();
+  socket.bind();
+  socket.on('listening', common.mustCall(() => {
+    const sockets = process.getActiveResourcesInfo().filter((item) => {
+      return item === 'UDPWrap';
+    });
+    assert.ok(sockets.length === 0);
+    process.disconnect();
+  }));
+}