Skip to content

Commit

Permalink
test: refactor test-beforeexit-event
Browse files Browse the repository at this point in the history
- replaced var with const/let.
- removed all console.log() statements.
- removed deaths and revivals vars.
- wrapped beforexit listener callbacks with
  common.mustCall().
- removed exit event listener.

PR-URL: #10121
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
  • Loading branch information
radelmann authored and addaleax committed Dec 7, 2016
1 parent c6eae5a commit 8960383
Showing 1 changed file with 12 additions and 28 deletions.
40 changes: 12 additions & 28 deletions test/parallel/test-beforeexit-event.js
Original file line number Diff line number Diff line change
@@ -1,42 +1,26 @@
'use strict';
require('../common');
var assert = require('assert');
var net = require('net');
var revivals = 0;
var deaths = 0;
const common = require('../common');
const net = require('net');

process.on('beforeExit', function() { deaths++; });

process.once('beforeExit', tryImmediate);
process.once('beforeExit', common.mustCall(tryImmediate));

function tryImmediate() {
console.log('set immediate');
setImmediate(function() {
revivals++;
process.once('beforeExit', tryTimer);
});
setImmediate(common.mustCall(() => {
process.once('beforeExit', common.mustCall(tryTimer));
}));
}

function tryTimer() {
console.log('set a timeout');
setTimeout(function() {
console.log('timeout cb, do another once beforeExit');
revivals++;
process.once('beforeExit', tryListen);
}, 1);
setTimeout(common.mustCall(() => {
process.once('beforeExit', common.mustCall(tryListen));
}), 1);
}

function tryListen() {
console.log('create a server');
net.createServer()
.listen(0)
.on('listening', function() {
revivals++;
.on('listening', common.mustCall(function() {
this.close();
});
process.on('beforeExit', common.mustCall(() => {}));
}));
}

process.on('exit', function() {
assert.strictEqual(4, deaths);
assert.strictEqual(3, revivals);
});

0 comments on commit 8960383

Please sign in to comment.