url: handle URL.canParse without base parameter

PR-URL: #47547 Backport-PR-URL: #48345 Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 12, 2023 · 8897305 · 8897305
1 parent 0dc485e
commit 8897305
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -115,7 +115,7 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
 
 // TODO(@anonrig): Add V8 Fast API for CanParse method
 void BindingData::CanParse(const FunctionCallbackInfo<Value>& args) {
-  CHECK_GE(args.Length(), 2);
+  CHECK_GE(args.Length(), 1);
   CHECK(args[0]->IsString());  // input
   // args[1] // base url
 

diff --git a/test/parallel/test-whatwg-url-canparse.js b/test/parallel/test-whatwg-url-canparse.js
@@ -0,0 +1,21 @@
+// Flags: --expose-internals
+'use strict';
+
+require('../common');
+
+const { URL } = require('url');
+const assert = require('assert');
+
+let internalBinding;
+try {
+  internalBinding = require('internal/test/binding').internalBinding;
+} catch (e) {
+  console.log('using `test/parallel/test-whatwg-url-canparse` requires `--expose-internals`');
+  throw e;
+}
+
+const { canParse } = internalBinding('url');
+
+// It should not throw when called without a base string
+assert.strictEqual(URL.canParse('https://example.org'), true);
+assert.strictEqual(canParse('https://example.org'), true);