lib: fix incorrect use of console intrinsic

The console object was not being frozen because the intrinsic freezing code was accessing undefined instead of the console object. PR-URL: #46044 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jan 20, 2023 · 8684dae · 8684dae
1 parent e90a3a6
commit 8684dae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/freeze_intrinsics.js b/lib/internal/freeze_intrinsics.js
@@ -135,7 +135,7 @@ const {
 
 module.exports = function() {
   const { Console } = require('internal/console/constructor');
-  const { console } = require('internal/console/global');
+  const console = require('internal/console/global');
   const {
     clearImmediate,
     clearInterval,

diff --git a/test/parallel/test-freeze-intrinsics.js b/test/parallel/test-freeze-intrinsics.js
@@ -37,3 +37,12 @@ assert.throws(
                 { name: 'TypeError' });
   assert.strictEqual(globalThis.globalThis, globalThis);
 }
+
+// Ensure that we cannot override console properties.
+{
+  const { log } = console;
+
+  assert.throws(() => { console.log = null; },
+                { name: 'TypeError' });
+  assert.strictEqual(console.log, log);
+}