assert: fix loose deepEqual map comparison

Loose map comparison had an logic error. It will now be properly compared. PR-URL: #24749 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Dec 5, 2018 · 7fb8d31 · 7fb8d31
1 parent 4d41c8f
commit 7fb8d31
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -416,9 +416,7 @@ function mapMightHaveLoosePrim(a, b, prim, item, memo) {
       !innerDeepEqual(item, curB, false, memo)) {
     return false;
   }
-  const curA = a.get(altValue);
-  return curA === undefined && a.has(altValue) ||
-         innerDeepEqual(item, curA, false, memo);
+  return !a.has(altValue) && innerDeepEqual(item, curB, false, memo);
 }
 
 function setEquiv(a, b, strict, memo) {

diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -394,6 +394,14 @@ assertOnlyDeepEqual(
   new Map([[1, {}]]),
   new Map([[true, {}]])
 );
+assertOnlyDeepEqual(
+  new Map([[undefined, true]]),
+  new Map([[null, true]])
+);
+assertNotDeepOrStrict(
+  new Map([[undefined, true]]),
+  new Map([[true, true]])
+);
 
 // GH-6416. Make sure circular refs don't throw.
 {