readline: replace quadratic regex with linear one

Simplify regular expression in _wordLeft and _deleteWordLeft readline methods. PR-URL: #26778 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
nodejs · Apr 9, 2019 · 78fad32 · 78fad32
1 parent e5181f8
commit 78fad32
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/lib/readline.js b/lib/readline.js
@@ -569,8 +569,11 @@ function commonPrefix(strings) {
 
 Interface.prototype._wordLeft = function() {
   if (this.cursor > 0) {
+    // Reverse the string and match a word near beginning
+    // to avoid quadratic time complexity
     var leading = this.line.slice(0, this.cursor);
-    var match = leading.match(/(?:[^\w\s]+|\w+|)\s*$/);
+    var reversed = leading.split('').reverse().join('');
+    var match = reversed.match(/^\s*(?:[^\w\s]+|\w+)?/);
     this._moveCursor(-match[0].length);
   }
 };
@@ -626,8 +629,11 @@ Interface.prototype._deleteRight = function() {
 
 Interface.prototype._deleteWordLeft = function() {
   if (this.cursor > 0) {
+    // Reverse the string and match a word near beginning
+    // to avoid quadratic time complexity
     var leading = this.line.slice(0, this.cursor);
-    var match = leading.match(/(?:[^\w\s]+|\w+|)\s*$/);
+    var reversed = leading.split('').reverse().join('');
+    var match = reversed.match(/^\s*(?:[^\w\s]+|\w+)?/);
     leading = leading.slice(0, leading.length - match[0].length);
     this.line = leading + this.line.slice(this.cursor, this.line.length);
     this.cursor = leading.length;

diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js
@@ -1272,3 +1272,26 @@ const crlfDelay = Infinity;
     }), delay);
   }
 });
+
+// Ensure that the _wordLeft method works even for large input
+{
+  const input = new Readable({
+    read() {
+      this.push('\x1B[1;5D'); // CTRL + Left
+      this.push(null);
+    },
+  });
+  const output = new Writable({
+    write: common.mustCall((data, encoding, cb) => {
+      assert.strictEqual(rl.cursor, rl.line.length - 1);
+      cb();
+    }),
+  });
+  const rl = new readline.createInterface({
+    input: input,
+    output: output,
+    terminal: true,
+  });
+  rl.line = `a${' '.repeat(1e6)}a`;
+  rl.cursor = rl.line.length;
+}