lib: refactor setupInspector in bootstrap/node.js

`CJSModule` is not used in `setupGlobalConsole`, so we can move it to `setupInspector` and remove the argument from `setupInspector`. PR-URL: #24446 Reviewed-By: Ouyang Yadong <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
nodejs · Nov 20, 2018 · 771585f · 771585f
1 parent 47495e0
commit 771585f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -439,7 +439,6 @@
 
   function setupGlobalConsole() {
     const originalConsole = global.console;
-    const CJSModule = NativeModule.require('internal/modules/cjs/loader');
     // Setup Node.js global.console.
     const wrappedConsole = NativeModule.require('console');
     Object.defineProperty(global, 'console', {
@@ -448,7 +447,7 @@
       value: wrappedConsole,
       writable: true
     });
-    setupInspector(originalConsole, wrappedConsole, CJSModule);
+    setupInspector(originalConsole, wrappedConsole);
   }
 
   function setupGlobalURL() {
@@ -521,10 +520,11 @@
     NativeModule.require('internal/domexception');
   }
 
-  function setupInspector(originalConsole, wrappedConsole, CJSModule) {
+  function setupInspector(originalConsole, wrappedConsole) {
     if (!process.config.variables.v8_enable_inspector) {
       return;
     }
+    const CJSModule = NativeModule.require('internal/modules/cjs/loader');
     const { addCommandLineAPI, consoleCall } = process.binding('inspector');
     // Setup inspector command line API.
     const { makeRequireFunction } =