From 75e5612fae10a15f49340a2317adc2ccff400fbb Mon Sep 17 00:00:00 2001
From: Rafael Gonzaga <rafael.nunu@hotmail.com>
Date: Sat, 1 Jun 2024 10:13:12 -0300
Subject: [PATCH] src,permission: --allow-wasi & prevent WASI exec

PR-URL: https://github.com/nodejs/node/pull/53124
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/cli.md                                | 50 +++++++++++++++++++
 doc/api/permissions.md                        |  6 ++-
 doc/node.1                                    |  3 ++
 lib/internal/process/pre_execution.js         |  2 +
 node.gyp                                      |  2 +
 src/env.cc                                    |  3 ++
 src/node_options.cc                           |  4 ++
 src/node_options.h                            |  1 +
 src/node_wasi.cc                              | 12 +++--
 src/permission/permission.cc                  |  5 ++
 src/permission/permission.h                   |  1 +
 src/permission/permission_base.h              |  3 ++
 src/permission/wasi_permission.cc             | 25 ++++++++++
 src/permission/wasi_permission.h              | 31 ++++++++++++
 .../test-permission-allow-wasi-cli.js         | 22 ++++++++
 .../parallel/test-permission-warning-flags.js |  1 +
 test/parallel/test-permission-wasi.js         | 19 +++++++
 17 files changed, 183 insertions(+), 7 deletions(-)
 create mode 100644 src/permission/wasi_permission.cc
 create mode 100644 src/permission/wasi_permission.h
 create mode 100644 test/parallel/test-permission-allow-wasi-cli.js
 create mode 100644 test/parallel/test-permission-wasi.js

diff --git a/doc/api/cli.md b/doc/api/cli.md
index 9397b4e24a348f..b983e2e0afc24b 100644
--- a/doc/api/cli.md
+++ b/doc/api/cli.md
@@ -269,6 +269,53 @@ Examples can be found in the [File System Permissions][] documentation.
 
 Relative paths are NOT supported through the CLI flag.
 
+### `--allow-wasi`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1.1 - Active development
+
+When using the [Permission Model][], the process will not be capable of creating
+any WASI instances by default.
+For security reasons, the call will throw an `ERR_ACCESS_DENIED` unless the
+user explicitly passes the flag `--allow-wasi` in the main Node.js process.
+
+Example:
+
+```js
+const { WASI } = require('node:wasi');
+// Attempt to bypass the permission
+new WASI({
+  version: 'preview1',
+  // Attempt to mount the whole filesystem
+  preopens: {
+    '/': '/',
+  },
+});
+```
+
+```console
+$ node --experimental-permission --allow-fs-read=* index.js
+node:wasi:99
+    const wrap = new _WASI(args, env, preopens, stdio);
+                 ^
+
+Error: Access to this API has been restricted
+    at new WASI (node:wasi:99:18)
+    at Object.<anonymous> (/home/index.js:3:1)
+    at Module._compile (node:internal/modules/cjs/loader:1476:14)
+    at Module._extensions..js (node:internal/modules/cjs/loader:1555:10)
+    at Module.load (node:internal/modules/cjs/loader:1288:32)
+    at Module._load (node:internal/modules/cjs/loader:1104:12)
+    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:191:14)
+    at node:internal/main/run_main_module:30:49 {
+  code: 'ERR_ACCESS_DENIED',
+  permission: 'WASI',
+}
+```
+
 ### `--allow-worker`
 
 <!-- YAML
@@ -925,6 +972,7 @@ following permissions are restricted:
   [`--allow-fs-read`][], [`--allow-fs-write`][] flags
 * Child Process - manageable through [`--allow-child-process`][] flag
 * Worker Threads - manageable through [`--allow-worker`][] flag
+* WASI - manageable through [`--allow-wasi`][] flag
 
 ### `--experimental-require-module`
 
@@ -2738,6 +2786,7 @@ one is included in the list below.
 * `--allow-child-process`
 * `--allow-fs-read`
 * `--allow-fs-write`
+* `--allow-wasi`
 * `--allow-worker`
 * `--conditions`, `-C`
 * `--diagnostic-dir`
@@ -3293,6 +3342,7 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
 [`--allow-child-process`]: #--allow-child-process
 [`--allow-fs-read`]: #--allow-fs-read
 [`--allow-fs-write`]: #--allow-fs-write
+[`--allow-wasi`]: #--allow-wasi
 [`--allow-worker`]: #--allow-worker
 [`--build-snapshot`]: #--build-snapshot
 [`--cpu-prof-dir`]: #--cpu-prof-dir
diff --git a/doc/api/permissions.md b/doc/api/permissions.md
index 5012c34597685e..d994035c808818 100644
--- a/doc/api/permissions.md
+++ b/doc/api/permissions.md
@@ -482,7 +482,7 @@ flag.
 
 When starting Node.js with `--experimental-permission`,
 the ability to access the file system through the `fs` module, spawn processes,
-use `node:worker_threads`, native addons, and enable the runtime inspector
+use `node:worker_threads`, use native addons, use WASI, and enable the runtime inspector
 will be restricted.
 
 ```console
@@ -507,7 +507,7 @@ Allowing access to spawning a process and creating worker threads can be done
 using the [`--allow-child-process`][] and [`--allow-worker`][] respectively.
 
 To allow native addons when using permission model, use the [`--allow-addons`][]
-flag.
+flag. For WASI, use the [`--allow-wasi`][] flag.
 
 #### Runtime API
 
@@ -574,6 +574,7 @@ There are constraints you need to know before using this system:
   * Worker Threads
   * Inspector protocol
   * File system access
+  * WASI
 * The Permission Model is initialized after the Node.js environment is set up.
   However, certain flags such as `--env-file` or `--openssl-config` are designed
   to read files before environment initialization. As a result, such flags are
@@ -597,6 +598,7 @@ There are constraints you need to know before using this system:
 [`--allow-child-process`]: cli.md#--allow-child-process
 [`--allow-fs-read`]: cli.md#--allow-fs-read
 [`--allow-fs-write`]: cli.md#--allow-fs-write
+[`--allow-wasi`]: cli.md#--allow-wasi
 [`--allow-worker`]: cli.md#--allow-worker
 [`--experimental-permission`]: cli.md#--experimental-permission
 [`permission.has()`]: process.md#processpermissionhasscope-reference
diff --git a/doc/node.1 b/doc/node.1
index 90e974b7fb83bb..7fe2e4b6a2a885 100644
--- a/doc/node.1
+++ b/doc/node.1
@@ -88,6 +88,9 @@ Allow using native addons when using the permission model.
 .It Fl -allow-child-process
 Allow spawning process when using the permission model.
 .
+.It Fl -allow-wasi
+Allow execution of WASI when using the permission model.
+.
 .It Fl -allow-worker
 Allow creating worker threads when using the permission model.
 .
diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js
index c1445a5d77b562..cf5b75b331c1d9 100644
--- a/lib/internal/process/pre_execution.js
+++ b/lib/internal/process/pre_execution.js
@@ -590,6 +590,7 @@ function initializePermission() {
     const warnFlags = [
       '--allow-addons',
       '--allow-child-process',
+      '--allow-wasi',
       '--allow-worker',
     ];
     for (const flag of warnFlags) {
@@ -631,6 +632,7 @@ function initializePermission() {
       '--allow-fs-write',
       '--allow-addons',
       '--allow-child-process',
+      '--allow-wasi',
       '--allow-worker',
     ];
     ArrayPrototypeForEach(availablePermissionFlags, (flag) => {
diff --git a/node.gyp b/node.gyp
index 84788c8fc6eb5e..2a8e6a66f58261 100644
--- a/node.gyp
+++ b/node.gyp
@@ -153,6 +153,7 @@
       'src/permission/fs_permission.cc',
       'src/permission/inspector_permission.cc',
       'src/permission/permission.cc',
+      'src/permission/wasi_permission.cc',
       'src/permission/worker_permission.cc',
       'src/pipe_wrap.cc',
       'src/process_wrap.cc',
@@ -277,6 +278,7 @@
       'src/permission/fs_permission.h',
       'src/permission/inspector_permission.h',
       'src/permission/permission.h',
+      'src/permission/wasi_permission.h',
       'src/permission/worker_permission.h',
       'src/pipe_wrap.h',
       'src/req_wrap.h',
diff --git a/src/env.cc b/src/env.cc
index 3d36416cdfa0f9..73981071f6cce5 100644
--- a/src/env.cc
+++ b/src/env.cc
@@ -921,6 +921,9 @@ Environment::Environment(IsolateData* isolate_data,
       permission()->Apply(
           this, {"*"}, permission::PermissionScope::kWorkerThreads);
     }
+    if (!options_->allow_wasi) {
+      permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+    }
 
     if (!options_->allow_fs_read.empty()) {
       permission()->Apply(this,
diff --git a/src/node_options.cc b/src/node_options.cc
index 0b9d1766fb4ad4..508040f3fbe955 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -468,6 +468,10 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             "allow use of child process when any permissions are set",
             &EnvironmentOptions::allow_child_process,
             kAllowedInEnvvar);
+  AddOption("--allow-wasi",
+            "allow wasi when any permissions are set",
+            &EnvironmentOptions::allow_wasi,
+            kAllowedInEnvvar);
   AddOption("--allow-worker",
             "allow worker threads when any permissions are set",
             &EnvironmentOptions::allow_worker_threads,
diff --git a/src/node_options.h b/src/node_options.h
index fba836a4926747..d90ba30b644b35 100644
--- a/src/node_options.h
+++ b/src/node_options.h
@@ -131,6 +131,7 @@ class EnvironmentOptions : public Options {
   std::vector<std::string> allow_fs_write;
   bool allow_addons = false;
   bool allow_child_process = false;
+  bool allow_wasi = false;
   bool allow_worker_threads = false;
   bool experimental_repl_await = true;
   bool experimental_vm_modules = false;
diff --git a/src/node_wasi.cc b/src/node_wasi.cc
index 9c1707ec3ad230..ad1da44a01f437 100644
--- a/src/node_wasi.cc
+++ b/src/node_wasi.cc
@@ -1,14 +1,15 @@
-#include "env-inl.h"
+#include "node_wasi.h"
 #include "base_object-inl.h"
 #include "debug_utils-inl.h"
+#include "env-inl.h"
 #include "memory_tracker-inl.h"
-#include "node_mem-inl.h"
-#include "util-inl.h"
 #include "node.h"
 #include "node_errors.h"
+#include "node_mem-inl.h"
+#include "permission/permission.h"
+#include "util-inl.h"
 #include "uv.h"
 #include "uvwasi.h"
-#include "node_wasi.h"
 
 namespace node {
 namespace wasi {
@@ -120,8 +121,9 @@ void WASI::New(const FunctionCallbackInfo<Value>& args) {
   CHECK(args[1]->IsArray());
   CHECK(args[2]->IsArray());
   CHECK(args[3]->IsArray());
-
   Environment* env = Environment::GetCurrent(args);
+  THROW_IF_INSUFFICIENT_PERMISSIONS(
+      env, permission::PermissionScope::kWASI, "");
   Local<Context> context = env->context();
   Local<Array> argv = args[0].As<Array>();
   const uint32_t argc = argv->Length();
diff --git a/src/permission/permission.cc b/src/permission/permission.cc
index c2f1bf0a5ddab9..ad393df0e38976 100644
--- a/src/permission/permission.cc
+++ b/src/permission/permission.cc
@@ -82,6 +82,7 @@ Permission::Permission() : enabled_(false) {
       std::make_shared<WorkerPermission>();
   std::shared_ptr<PermissionBase> inspector =
       std::make_shared<InspectorPermission>();
+  std::shared_ptr<PermissionBase> wasi = std::make_shared<WASIPermission>();
 #define V(Name, _, __)                                                         \
   nodes_.insert(std::make_pair(PermissionScope::k##Name, fs));
   FILESYSTEM_PERMISSIONS(V)
@@ -98,6 +99,10 @@ Permission::Permission() : enabled_(false) {
   nodes_.insert(std::make_pair(PermissionScope::k##Name, inspector));
   INSPECTOR_PERMISSIONS(V)
 #undef V
+#define V(Name, _, __)                                                         \
+  nodes_.insert(std::make_pair(PermissionScope::k##Name, wasi));
+  WASI_PERMISSIONS(V)
+#undef V
 }
 
 Local<Value> CreateAccessDeniedError(Environment* env,
diff --git a/src/permission/permission.h b/src/permission/permission.h
index 2dfba1d35f0991..55309b6ba551c2 100644
--- a/src/permission/permission.h
+++ b/src/permission/permission.h
@@ -9,6 +9,7 @@
 #include "permission/fs_permission.h"
 #include "permission/inspector_permission.h"
 #include "permission/permission_base.h"
+#include "permission/wasi_permission.h"
 #include "permission/worker_permission.h"
 #include "v8.h"
 
diff --git a/src/permission/permission_base.h b/src/permission/permission_base.h
index ea0226c73adc1b..d4ab33d10142f2 100644
--- a/src/permission/permission_base.h
+++ b/src/permission/permission_base.h
@@ -21,6 +21,8 @@ namespace permission {
 
 #define CHILD_PROCESS_PERMISSIONS(V) V(ChildProcess, "child", PermissionsRoot)
 
+#define WASI_PERMISSIONS(V) V(WASI, "wasi", PermissionsRoot)
+
 #define WORKER_THREADS_PERMISSIONS(V)                                          \
   V(WorkerThreads, "worker", PermissionsRoot)
 
@@ -29,6 +31,7 @@ namespace permission {
 #define PERMISSIONS(V)                                                         \
   FILESYSTEM_PERMISSIONS(V)                                                    \
   CHILD_PROCESS_PERMISSIONS(V)                                                 \
+  WASI_PERMISSIONS(V)                                                          \
   WORKER_THREADS_PERMISSIONS(V)                                                \
   INSPECTOR_PERMISSIONS(V)
 
diff --git a/src/permission/wasi_permission.cc b/src/permission/wasi_permission.cc
new file mode 100644
index 00000000000000..625b61cf1c1bbe
--- /dev/null
+++ b/src/permission/wasi_permission.cc
@@ -0,0 +1,25 @@
+#include "permission/wasi_permission.h"
+
+#include <string>
+#include <vector>
+
+namespace node {
+
+namespace permission {
+
+// Currently, WASIPermission manage a single state
+// Once denied, it's always denied
+void WASIPermission::Apply(Environment* env,
+                           const std::vector<std::string>& allow,
+                           PermissionScope scope) {
+  deny_all_ = true;
+}
+
+bool WASIPermission::is_granted(Environment* env,
+                                PermissionScope perm,
+                                const std::string_view& param) const {
+  return deny_all_ == false;
+}
+
+}  // namespace permission
+}  // namespace node
diff --git a/src/permission/wasi_permission.h b/src/permission/wasi_permission.h
new file mode 100644
index 00000000000000..2a12592d142eea
--- /dev/null
+++ b/src/permission/wasi_permission.h
@@ -0,0 +1,31 @@
+#ifndef SRC_PERMISSION_WASI_PERMISSION_H_
+#define SRC_PERMISSION_WASI_PERMISSION_H_
+
+#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
+
+#include <vector>
+#include "permission/permission_base.h"
+
+namespace node {
+
+namespace permission {
+
+class WASIPermission final : public PermissionBase {
+ public:
+  void Apply(Environment* env,
+             const std::vector<std::string>& allow,
+             PermissionScope scope) override;
+  bool is_granted(Environment* env,
+                  PermissionScope perm,
+                  const std::string_view& param = "") const override;
+
+ private:
+  bool deny_all_;
+};
+
+}  // namespace permission
+
+}  // namespace node
+
+#endif  // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
+#endif  // SRC_PERMISSION_WASI_PERMISSION_H_
diff --git a/test/parallel/test-permission-allow-wasi-cli.js b/test/parallel/test-permission-allow-wasi-cli.js
new file mode 100644
index 00000000000000..f6f1cfe3c895fb
--- /dev/null
+++ b/test/parallel/test-permission-allow-wasi-cli.js
@@ -0,0 +1,22 @@
+// Flags: --experimental-permission --allow-wasi --allow-fs-read=*
+'use strict';
+
+const common = require('../common');
+common.skipIfWorker();
+
+const assert = require('assert');
+const { WASI } = require('wasi');
+
+// Guarantee the initial state
+{
+  assert.ok(process.permission.has('wasi'));
+}
+
+// When a permission is set by cli, the process shouldn't be able
+// to create WASI instance unless --allow-wasi is sent
+{
+  // doesNotThrow
+  new WASI({
+    version: 'preview1',
+  });
+}
diff --git a/test/parallel/test-permission-warning-flags.js b/test/parallel/test-permission-warning-flags.js
index ce3df71bc95f7c..87fcb7ff7f3158 100644
--- a/test/parallel/test-permission-warning-flags.js
+++ b/test/parallel/test-permission-warning-flags.js
@@ -7,6 +7,7 @@ const assert = require('assert');
 const warnFlags = [
   '--allow-addons',
   '--allow-child-process',
+  '--allow-wasi',
   '--allow-worker',
 ];
 
diff --git a/test/parallel/test-permission-wasi.js b/test/parallel/test-permission-wasi.js
new file mode 100644
index 00000000000000..1a6cde013097b7
--- /dev/null
+++ b/test/parallel/test-permission-wasi.js
@@ -0,0 +1,19 @@
+// Flags: --experimental-permission --allow-fs-read=*
+'use strict';
+
+const common = require('../common');
+const assert = require('node:assert');
+
+const { WASI } = require('wasi');
+
+{
+  assert.throws(() => {
+    new WASI({
+      version: 'preview1',
+      preopens: { '/': '/' },
+    });
+  }, common.expectsError({
+    code: 'ERR_ACCESS_DENIED',
+    permission: 'WASI',
+  }));
+}