assert: replace many if's with if-else statement

Replace multiple mutually exclusive `if` statements with if-else statements. PR-URL: #14043 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: David Cai <[email protected]>
nodejs · Jul 5, 2017 · 6e86a70 · 6e86a70
1 parent b01ac75
commit 6e86a70
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -62,18 +62,20 @@ function innerFail(actual, expected, message, operator, stackStartFunction) {
 }
 
 function fail(actual, expected, message, operator, stackStartFunction) {
-  if (arguments.length === 0) {
+  const argsLen = arguments.length;
+
+  if (argsLen === 0) {
     message = 'Failed';
-  }
-  if (arguments.length === 1) {
+  } else if (argsLen === 1) {
     message = actual;
     actual = undefined;
-  }
-  if (arguments.length === 2) {
+  } else if (argsLen === 2) {
     operator = '!=';
   }
+
   innerFail(actual, expected, message, operator, stackStartFunction || fail);
 }
+
 assert.fail = fail;
 
 // The AssertionError is defined in internal/error.