test: add test for options validation of createServer

PR-URL: #30541 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Dec 17, 2019 · 6da56e9 · 6da56e9
1 parent e10f922
commit 6da56e9
Show file tree

Hide file tree

Showing 3 changed files with 70 additions and 22 deletions.
diff --git a/test/parallel/test-http2-createsecureserver-nooptions.js b/test/parallel/test-http2-createsecureserver-nooptions.js
diff --git a/test/parallel/test-http2-createsecureserver-options.js b/test/parallel/test-http2-createsecureserver-options.js
@@ -0,0 +1,35 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const http2 = require('http2');
+
+// Error if invalid options are passed to createSecureServer
+const invalidOptions = [() => {}, 1, 'test', null, Symbol('test')];
+invalidOptions.forEach((invalidOption) => {
+  assert.throws(
+    () => http2.createSecureServer(invalidOption),
+    {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'The "options" argument must be of type Object. Received ' +
+               `type ${typeof invalidOption}`
+    }
+  );
+});
+
+// Error if invalid options.settings are passed to createSecureServer
+invalidOptions.forEach((invalidSettingsOption) => {
+  assert.throws(
+    () => http2.createSecureServer({ settings: invalidSettingsOption }),
+    {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'The "options.settings" property must be of type Object. ' +
+               `Received type ${typeof invalidSettingsOption}`
+    }
+  );
+});
diff --git a/test/parallel/test-http2-createserver-options.js b/test/parallel/test-http2-createserver-options.js
@@ -0,0 +1,35 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const assert = require('assert');
+const http2 = require('http2');
+
+// Error if invalid options are passed to createServer
+const invalidOptions = [1, true, 'test', null, Symbol('test')];
+invalidOptions.forEach((invalidOption) => {
+  assert.throws(
+    () => http2.createServer(invalidOption),
+    {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'The "options" argument must be of type Object. Received ' +
+               `type ${typeof invalidOption}`
+    }
+  );
+});
+
+// Error if invalid options.settings are passed to createServer
+invalidOptions.forEach((invalidSettingsOption) => {
+  assert.throws(
+    () => http2.createServer({ settings: invalidSettingsOption }),
+    {
+      name: 'TypeError',
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: 'The "options.settings" property must be of type Object. ' +
+               `Received type ${typeof invalidSettingsOption}`
+    }
+  );
+});