From 6d77df840c4a38a95d8218322b6e92ee5cf3a7b2 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 16 Apr 2020 05:35:01 -0400 Subject: [PATCH] build: remove .git folders when testing V8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by: Richard Lau PR-URL: https://github.com/nodejs/node/pull/32877 Refs: https://github.com/nodejs/build/issues/2256 Reviewed-By: Michaël Zasso Reviewed-By: Matheus Marchini Reviewed-By: Anna Henningsen --- tools/make-v8.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/make-v8.sh b/tools/make-v8.sh index e4024330b169db..68222c1cd8ba9f 100755 --- a/tools/make-v8.sh +++ b/tools/make-v8.sh @@ -4,6 +4,7 @@ BUILD_ARCH_TYPE=$1 V8_BUILD_OPTIONS=$2 cd deps/v8 +find . -type d -name .git | xargs rm -rf tools/node/fetch_deps.py . ARCH="`arch`"