Skip to content

Commit

Permalink
src: remove empty name check in node_env_var.cc
Browse files Browse the repository at this point in the history
The empty name check has been removed since this has landed:
libuv/libuv#2473

PR-URL: #36133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
RaisinTen authored and targos committed Dec 21, 2020
1 parent d8b5b94 commit 68687d3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/node_env_var.cc
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,7 @@ Local<Array> RealEnvStore::Enumerate(Isolate* isolate) const {
for (int i = 0; i < count; i++) {
#ifdef _WIN32
// If the key starts with '=' it is a hidden environment variable.
// The '\0' check is a workaround for the bug behind
// https://github.com/libuv/libuv/pull/2473 and can be removed later.
if (items[i].name[0] == '=' || items[i].name[0] == '\0') continue;
if (items[i].name[0] == '=') continue;
#endif
MaybeLocal<String> str = String::NewFromUtf8(isolate, items[i].name);
if (str.IsEmpty()) {
Expand Down

0 comments on commit 68687d3

Please sign in to comment.