src: remove KeyObjectData::CreateSecret overload

This function is unused and there is not much potential for using it in the current codebase. PR-URL: #38067 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Apr 6, 2021 · 66c8f76 · 66c8f76
1 parent f52c921
commit 66c8f76
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/src/crypto/crypto_keys.cc b/src/crypto/crypto_keys.cc
@@ -837,11 +837,6 @@ void KeyObjectData::MemoryInfo(MemoryTracker* tracker) const {
   }
 }
 
-std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(
-    const ArrayBufferOrViewContents<char>& buf) {
-  return CreateSecret(buf.ToCopy());
-}
-
 std::shared_ptr<KeyObjectData> KeyObjectData::CreateSecret(ByteSource key) {
   CHECK(key);
   return std::shared_ptr<KeyObjectData>(new KeyObjectData(std::move(key)));

diff --git a/src/crypto/crypto_keys.h b/src/crypto/crypto_keys.h
@@ -134,9 +134,6 @@ class ManagedEVPPKey : public MemoryRetainer {
 // Objects of this class can safely be shared among threads.
 class KeyObjectData : public MemoryRetainer {
  public:
-  static std::shared_ptr<KeyObjectData> CreateSecret(
-      const ArrayBufferOrViewContents<char>& buf);
-
   static std::shared_ptr<KeyObjectData> CreateSecret(ByteSource key);
 
   static std::shared_ptr<KeyObjectData> CreateAsymmetric(