test: ignore connection errors for hostname check

PR-URL: #14073 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Jul 19, 2017 · 628fc49 · 628fc49
1 parent 0a462fb
commit 628fc49
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/test/parallel/test-http-hostname-typechecking.js b/test/parallel/test-http-hostname-typechecking.js
@@ -18,10 +18,12 @@ vals.forEach((v) => {
   assert.throws(() => http.request({host: v}), errHost);
 });
 
-// These values are OK and should not throw synchronously
+// These values are OK and should not throw synchronously.
+// Only testing for 'hostname' validation so ignore connection errors.
+const dontCare = () => {};
 ['', undefined, null].forEach((v) => {
   assert.doesNotThrow(() => {
-    http.request({hostname: v}).on('error', () => {}).end();
-    http.request({host: v}).on('error', () => {}).end();
+    http.request({hostname: v}).on('error', dontCare).end();
+    http.request({host: v}).on('error', dontCare).end();
   });
 });