Skip to content

Commit

Permalink
debugger: use requireRepl() to load debugger repl
Browse files Browse the repository at this point in the history
Currently, the debugger uses require('repl') to setup the repl.
However, require.extensions is not available yet, causing a
crash on tab completion of require('. This commit uses the
module.requireRepl() method to bootstrap the repl.

Fixes: nodejs/node-v0.x-archive#8359
PR-URL: #49
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
cjihrig committed Dec 6, 2014
1 parent 244a8f7 commit 616343b
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/_debugger.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ var util = require('util'),
path = require('path'),
net = require('net'),
vm = require('vm'),
repl = require('repl'),
module = require('module'),
repl = module.requireRepl(),
inherits = util.inherits,
assert = require('assert'),
spawn = require('child_process').spawn;
Expand Down Expand Up @@ -776,6 +777,7 @@ function Interface(stdin, stdout, args) {
if (parseInt(process.env['NODE_DISABLE_COLORS'], 10)) {
opts.useColors = false;
}

this.repl = repl.start(opts);

// Do not print useless warning
Expand Down Expand Up @@ -1129,7 +1131,7 @@ Interface.prototype.list = function(delta) {
if (lineno == 1) {
// The first line needs to have the module wrapper filtered out of
// it.
var wrapper = require('module').wrapper[0];
var wrapper = module.wrapper[0];
lines[i] = lines[i].slice(wrapper.length);

client.currentSourceColumn -= wrapper.length;
Expand Down
15 changes: 15 additions & 0 deletions test/simple/test-repl-tab-complete.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,18 @@ testMe.complete(' ', function(error, data) {
testMe.complete('toSt', function(error, data) {
assert.deepEqual(data, [['toString'], 'toSt']);
});

// Tab complete provides built in libs for require()
putIn.run(['.clear']);

testMe.complete('require(\'', function(error, data) {
assert.strictEqual(error, null);
repl._builtinLibs.forEach(function(lib) {
assert.notStrictEqual(data[0].indexOf(lib), -1, lib + ' not found');
});
});

testMe.complete('require(\'n', function(error, data) {
assert.strictEqual(error, null);
assert.deepEqual(data, [['net'], 'n']);
});

0 comments on commit 616343b

Please sign in to comment.