src: emit 'params' instead of 'data' for NodeTracing.dataCollected

PR-URL: #24949 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 17, 2018 · 5f8950b · 5f8950b
1 parent d0270f3
commit 5f8950b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/inspector/tracing_agent.cc b/src/inspector/tracing_agent.cc
@@ -31,7 +31,7 @@ class InspectorTraceWriter : public node::tracing::AsyncTraceWriter {
       return;
     json_writer_.reset();
     std::ostringstream result(
-        "{\"method\":\"NodeTracing.dataCollected\",\"data\":",
+        "{\"method\":\"NodeTracing.dataCollected\",\"params\":",
         std::ostringstream::ate);
     result << stream_.str();
     result << "}";

diff --git a/test/parallel/test-inspector-tracing-domain.js b/test/parallel/test-inspector-tracing-domain.js
@@ -60,7 +60,7 @@ async function test() {
     await generateTrace();
   JSON.stringify(await post('NodeTracing.stop', { traceConfig }));
   session.disconnect();
-  assert(traceNotification.data.value.length > 0);
+  assert(traceNotification.params.value.length > 0);
   assert(tracingComplete);
   clearInterval(interval);
   console.log('Success');

diff --git a/test/parallel/test-trace-events-dynamic-enable.js b/test/parallel/test-trace-events-dynamic-enable.js
@@ -28,8 +28,8 @@ async function test() {
   const events = [];
   let tracingComplete = false;
   session.on('NodeTracing.dataCollected', (n) => {
-    assert.ok(n && n.data && n.data.value);
-    events.push(...n.data.value);  // append the events.
+    assert.ok(n && n.params && n.params.value);
+    events.push(...n.params.value);  // append the events.
   });
   session.on('NodeTracing.tracingComplete', () => tracingComplete = true);